fix(run-lighthouse-tests): remove dot from report dir #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it will allow upload reports using GitHub action artifacts without the need to `include-hidden-files`
There was a problem hiding this comment.
Pull Request Overview
This PR removes the dot from the report directory path in the run-lighthouse-tests action to enable uploading reports via GitHub action artifacts without requiring the inclusion of hidden files.
- Changed the OUTPUT_DIR constant definition in main.ts from a hidden directory (./.lhci) to a visible one (./lhci).
StyleShit
approved these changes
Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it will allow upload reports using GitHub action artifacts without the need to
include-hidden-files