[refactor] Make defaultPalette a variable

There is no need to have a function. Arrays are by default copied by value.

Author: elgopher

pi.go

@@ -38,7 +38,7 @@ var (
 	// found, then default 16 color palette is used.
 	//
 	// Can be freely read and updated. Changes will be visible immediately.
-	Palette [256]image.RGB = defaultPalette()
+	Palette [256]image.RGB = defaultPalette
 
 	// SpriteSheetWidth will be used if sprite-sheet.png was not found.
 	SpriteSheetWidth = defaultSpriteSheetWidth
@@ -84,7 +84,7 @@ func Reset() {
 	ScreenWidth = defaultScreenWidth
 	ScreenHeight = defaultScreenHeight
 	Color = 6
-	Palette = defaultPalette()
+	Palette = defaultPalette
 }
 
 // Boot initializes the engine based on user parameters such as ScreenWidth and ScreenHeight.

resources.go

@@ -55,24 +55,22 @@ func useSpriteSheet(b []byte) error {
 	return nil
 }
 
-func defaultPalette() [256]image.RGB {
-	//nolint:govet
-	return [256]image.RGB{
-		{0, 0, 0},
-		{0x1D, 0x2B, 0x53},
-		{0x7E, 0x25, 0x53},
-		{0x00, 0x87, 0x51},
-		{0xAB, 0x52, 0x36},
-		{0x5F, 0x57, 0x4F},
-		{0xC2, 0xC3, 0xC7},
-		{0xff, 0xf1, 0xe8},
-		{0xFF, 0x00, 0x4D},
-		{0xFF, 0xA3, 0x00},
-		{0xFF, 0xEC, 0x27},
-		{0x00, 0xE4, 0x36},
-		{0x29, 0xAD, 0xFF},
-		{0x83, 0x76, 0x9C},
-		{0xFF, 0x77, 0xA8},
-		{0xFF, 0xCC, 0xAA},
-	}
+//nolint:govet
+var defaultPalette = [256]image.RGB{
+	{0, 0, 0},
+	{0x1D, 0x2B, 0x53},
+	{0x7E, 0x25, 0x53},
+	{0x00, 0x87, 0x51},
+	{0xAB, 0x52, 0x36},
+	{0x5F, 0x57, 0x4F},
+	{0xC2, 0xC3, 0xC7},
+	{0xff, 0xf1, 0xe8},
+	{0xFF, 0x00, 0x4D},
+	{0xFF, 0xA3, 0x00},
+	{0xFF, 0xEC, 0x27},
+	{0x00, 0xE4, 0x36},
+	{0x29, 0xAD, 0xFF},
+	{0x83, 0x76, 0x9C},
+	{0xFF, 0x77, 0xA8},
+	{0xFF, 0xCC, 0xAA},
 }