message for empty draft , sent , archive handled. #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ketanMehtaa is attempting to deploy a commit to the Inbox Zero Team on Vercel. A member of the Team first needs to authorize it. |
elie222
reviewed
Feb 28, 2024
| @@ -4,17 +4,44 @@ import Image from "next/image"; | |||
| import { getCelebrationImage } from "@/utils/celebration"; | |||
| import { Button } from "@/components/Button"; | |||
|
|
|||
| export function Celebration(props: { message: string }) { | |||
| export function Celebration(props: { type: string }) { | |||
There was a problem hiding this comment.
Thanks. I'd just use the existing format and pass in the relevant message. No need to change the props. Or this component at all.
elie222
reviewed
Feb 28, 2024
|
Thanks. There's no need to show a celebration at all for drafts. You can have a simple message without any graphic for drafts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123