-
-
Notifications
You must be signed in to change notification settings - Fork 0
docs: "common:utils" --> ":common-utils" #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove the need for changing the groupId and artifactId in the app being tested.
WalkthroughThis update revises the snapshot publishing instructions in the README, simplifying the process and reducing the number of steps. It also changes the group and artifact IDs for the Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
utils/build.gradle (1)
9-11
: Suggest adding projectgroup
andversion
properties
To keep the publication settings and project metadata in sync, consider setting the Gradlegroup
andversion
at the module level. This makes the coordinates available to other plugins and tasks by default:def utilsGroupId = "ai.elimu" def utilsArtifactId = "common-utils" +group = utilsGroupId +version = utilsVersionNameREADME.md (2)
45-48
: Clarify repository replacement snippet
To make step 1 crystal clear, include a diff-style example showing how to switch tomavenLocal()
in yourutils/build.gradle
:publishing { repositories { - maven { - name = "GithubPackages" - url = uri("https://maven.pkg.github.com/elimu-ai/common-utils") - credentials(PasswordCredentials) - } + mavenLocal() } }
46-46
: Use explicit project path in Gradle command
Recommend updating step 2 to prefix the task with:utils:
for clarity:-./gradlew clean utils:publishReleasePublicationToMavenLocal +./gradlew clean :utils:publishReleasePublicationToMavenLocal
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md
(1 hunks)utils/build.gradle
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: build (windows-latest, 17)
- GitHub Check: build (windows-latest, 21)
- GitHub Check: build (macos-latest, 17)
- GitHub Check: lint
- GitHub Check: build (ubuntu-latest, 21)
- GitHub Check: build (macos-latest, 21)
- GitHub Check: build (ubuntu-latest, 17)
🔇 Additional comments (1)
utils/build.gradle (1)
10-11
: Align module coordinates for simplified publishing
In support of elimu.ai's mission to build innovative learning software that empowers out-of-school children to teach themselves basic reading📖, writing✍🏽 and math🔢 within 6 months, these changes update thegroupId
to"ai.elimu"
and theartifactId
to"common-utils"
, matching the JitPack coordinates and eliminating extra setup steps for snapshot testing.
Remove the need for changing the groupId and artifactId in the app being tested.
Changed the
groupId:artifactId
to match the one already used at https://jitpack.io/#ai.elimu/common-utilsIssue Number
Purpose
-SNAPSHOT
versions of this library.Technical Details
Testing Instructions
Regression Tests
Screenshots
Summary by CodeRabbit
Documentation
Chores