Feature request: fine grained interceptor control

[bcardarella]

Currently Interceptors are called per endpoint or per server. However, servers can have multiple functions. I'd like to be able to control the interceptors per function call.

[bcardarella]

I could technically get that information from the stream argument passed into the interceptor, is that the recommendation over supporting this in API?

[polvalente]

I think we could add :only and :except options to intercept, both of which would accept function names so we can better control the interceptors

[polvalente]

I could technically get that information from the stream argument passed into the interceptor, is that the recommendation over supporting this in API?

Yeah, I think you can use the service and method name fields to filter this inside your own interceptor code

[polvalente]

@bcardarella I think I have something on the directioyou need: https://github.com/elixir-grpc/grpc/compare/pv-feat/filtered-intercerptors

It's basically what we discussed above, but turned into a first class feature for interceptors.

Let me know if I missed something, or if this seems like a good solution

[bcardarella]

I don't know, I gave this some thought and wouldn't this deviate from the gRPC spec? I realize the dev experience would be improved but if the project's goals and limits are the spec then perhaps it's not a good idea.

[polvalente]

Not sure how adding this would deviate any more than what we already have. What I added as a first class feature can already be done exactly the same with the interceptor scheme we have: do some checks and decide whether to call the current interceptor's main code, or to skip to the next interceptor directly.

[bcardarella]

your call, I think it would be a nicer API to have