Fix hook order inside while loop #1615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonatanklosko
commented
Jun 17, 2025
Comment on lines
+315
to
318
| {initial, cache} = recur_composite(initial_arg, state, cache) | ||
|
|
||
| initial = | ||
| if token = get_token(cache) do |
There was a problem hiding this comment.
We need to recur on initial_arg first and use the cached token. Currently we get the token first, so it doesn't account for all the prior computation.
josevalim
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use tokens to order hooks, but currently when we enter
whileloop, we don't use the latest token, we always use the starting one. In certain cases this leads to outfeeds in unexpected order and results in an error.