Fix old TODO's related to minimum elixir version (#418)

* chore: fix todos related to minimum elixir version

* Update Readme to point to newest version in hex

* Code.fetch_docs/1 cannot handle bytecode directly

Author: sindrip

README.md

@@ -22,7 +22,7 @@ The package can be installed by adding `:protobuf` to your list of dependencies
 ```elixir
 def deps do
   [
-    {:protobuf, "~> 0.14.1"}
+    {:protobuf, "~> 0.15.0"}
   ]
 end
 ```

lib/protobuf/extension.ex

@@ -35,11 +35,8 @@ defmodule Protobuf.Extension do
 
   """
 
-  import Bitwise, only: [<<<: 2]
-
-  # TODO: replace bitshift with Integer.pow/2 when we depend on Elixir 1.12+.
   # 2^29, see https://developers.google.com/protocol-buffers/docs/proto#extensions
-  @max 1 <<< 29
+  @max Integer.pow(2, 29)
 
   @doc """
   Returns the maximum extension number.

lib/protobuf/wire/varint.ex

@@ -49,34 +49,32 @@ defmodule Protobuf.Wire.Varint do
   @max_bits 64
   @mask64 bsl(1, @max_bits) - 1
 
-  # generated: true is required here to silence compilation warnings in Elixir
-  # 1.10 and 1.11. OK to remove once we support only 1.12+
   @varints [
     {
       quote(do: <<0::1, value::7>>),
       quote(do: value)
     },
     {
       quote(do: <<1::1, x0::7, 0::1, x1::7>>),
-      quote(generated: true, do: x0 + bsl(x1, 7))
+      quote(do: x0 + bsl(x1, 7))
     },
     {
       quote(do: <<1::1, x0::7, 1::1, x1::7, 0::1, x2::7>>),
-      quote(generated: true, do: x0 + bsl(x1, 7) + bsl(x2, 14))
+      quote(do: x0 + bsl(x1, 7) + bsl(x2, 14))
     },
     {
       quote(do: <<1::1, x0::7, 1::1, x1::7, 1::1, x2::7, 0::1, x3::7>>),
-      quote(generated: true, do: x0 + bsl(x1, 7) + bsl(x2, 14) + bsl(x3, 21))
+      quote(do: x0 + bsl(x1, 7) + bsl(x2, 14) + bsl(x3, 21))
     },
     {
       quote(do: <<1::1, x0::7, 1::1, x1::7, 1::1, x2::7, 1::1, x3::7, 0::1, x4::7>>),
-      quote(generated: true, do: x0 + bsl(x1, 7) + bsl(x2, 14) + bsl(x3, 21) + bsl(x4, 28))
+      quote(do: x0 + bsl(x1, 7) + bsl(x2, 14) + bsl(x3, 21) + bsl(x4, 28))
     },
     {
       quote do
         <<1::1, x0::7, 1::1, x1::7, 1::1, x2::7, 1::1, x3::7, 1::1, x4::7, 0::1, x5::7>>
       end,
-      quote(generated: true) do
+      quote do
         x0 +
           bsl(x1, 7) +
           bsl(x2, 14) +
@@ -90,7 +88,7 @@ defmodule Protobuf.Wire.Varint do
         <<1::1, x0::7, 1::1, x1::7, 1::1, x2::7, 1::1, x3::7, 1::1, x4::7, 1::1, x5::7, 0::1,
           x6::7>>
       end,
-      quote(generated: true) do
+      quote do
         x0 +
           bsl(x1, 7) +
           bsl(x2, 14) +
@@ -105,7 +103,7 @@ defmodule Protobuf.Wire.Varint do
         <<1::1, x0::7, 1::1, x1::7, 1::1, x2::7, 1::1, x3::7, 1::1, x4::7, 1::1, x5::7, 1::1,
           x6::7, 0::1, x7::7>>
       end,
-      quote(generated: true) do
+      quote do
         x0 +
           bsl(x1, 7) +
           bsl(x2, 14) +
@@ -121,7 +119,7 @@ defmodule Protobuf.Wire.Varint do
         <<1::1, x0::7, 1::1, x1::7, 1::1, x2::7, 1::1, x3::7, 1::1, x4::7, 1::1, x5::7, 1::1,
           x6::7, 1::1, x7::7, 0::1, x8::7>>
       end,
-      quote(generated: true) do
+      quote do
         x0 +
           bsl(x1, 7) +
           bsl(x2, 14) +
@@ -138,7 +136,7 @@ defmodule Protobuf.Wire.Varint do
         <<1::1, x0::7, 1::1, x1::7, 1::1, x2::7, 1::1, x3::7, 1::1, x4::7, 1::1, x5::7, 1::1,
           x6::7, 1::1, x7::7, 1::1, x8::7, 0::1, x9::7>>
       end,
-      quote(generated: true) do
+      quote do
         v =
           x0 +
             bsl(x1, 7) +

test/protobuf/protoc/cli_integration_test.exs

@@ -1,16 +1,9 @@
 defmodule Protobuf.Protoc.CLIIntegrationTest do
   use ExUnit.Case, async: true
 
-  # TODO: Remove when we depend on Elixir 1.11+.
-  import Protobuf.TestHelpers, only: [tmp_dir: 1, fetch_docs_from_bytecode: 1], warn: false
-
   alias Protobuf.TestHelpers
 
-  if Version.match?(System.version(), ">= 1.11.0") do
-    @moduletag :tmp_dir
-  else
-    setup :tmp_dir
-  end
+  @moduletag :tmp_dir
 
   describe "with simple user.proto file" do
     setup %{tmp_dir: tmp_dir} do
@@ -108,7 +101,7 @@ defmodule Protobuf.Protoc.CLIIntegrationTest do
         path
         |> Code.compile_file()
         |> Enum.map(fn {mod, bytecode} ->
-          {mod, fetch_docs_from_bytecode(bytecode)}
+          {mod, TestHelpers.fetch_docs_from_bytecode(bytecode)}
         end)
 
       on_exit(fn ->

test/test_helper.exs

@@ -13,21 +13,6 @@ defmodule Protobuf.TestHelpers do
     end)
   end
 
-  # TODO: Remove when we depend on Elixir 1.11+.
-  def tmp_dir(context) do
-    dir_name =
-      "#{inspect(context[:case])}#{context[:describe]}#{context[:test]}"
-      |> String.downcase()
-      |> String.replace(["-", " ", ".", "_"], "_")
-
-    tmp_dir_name = Path.join(System.tmp_dir!(), dir_name)
-
-    File.rm_rf!(tmp_dir_name)
-    File.mkdir_p!(tmp_dir_name)
-
-    Map.put(context, :tmp_dir, tmp_dir_name)
-  end
-
   def read_generated_file(relative_path) do
     [__DIR__, "../generated", relative_path]
     |> Path.join()