-
Notifications
You must be signed in to change notification settings - Fork 54
Add Exqlite.TypeExtensions to allow more types to be stored in the database #333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
warmwaffles
merged 3 commits into
elixir-sqlite:main
from
aseigo:feature/type_extensions
Jun 20, 2025
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
defmodule Exqlite.TypeExtension do | ||
@moduledoc """ | ||
A behaviour that defines the API for extensions providing custom data loaders and dumpers | ||
for Ecto schemas. | ||
""" | ||
|
||
@doc """ | ||
Takes a value and convers it to data suitable for storage in the database. | ||
|
||
Returns a tagged :ok/:error tuple. If the value is not convertable by this | ||
extension, returns nil. | ||
""" | ||
@callback convert(value :: term) :: {:ok, term} | {:error, reason :: term} | nil | ||
end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going back and fourth on allowing
type_extensions
to benil
.On one hand, letting it default to nil, will make the pattern match be faster than matching with an empty list.
And then changing
Application.get_env(:exqlite, :type_extensions, [])
to beApplication.get_env(:exqlite, :type_extensions)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went back and forth as well .. I'm not sure the speed gain is really going to be noticeable, but it's easy enough to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See 704c9bd