fix: not honoring the paramRefreshToken name passed in. #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
This also fixes the conflict where you try and import both the password reset and the refresh trait since they both have rules. |
Author
|
any comments/feedback on this PR. Would much rather this be fixed in your repo them me having to form and maintain my own? |
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
@jamesrusso This pull request is rejected for the implementation, but the functional request is being pulled into the next feature release. |
amitdhongde
pushed a commit
that referenced
this pull request
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quick fix when the refresh token is not named "RefreshToken". Honor the parameter.