Search highlighting across multiple buffers#1091
Open
ChoppinBlockParty wants to merge 3 commits into
Open
Conversation
ChoppinBlockParty
force-pushed
the
all-windows-highlighting-ex-search
branch
from
a4cf6d7 to
c82ec11
Compare
ChoppinBlockParty
force-pushed
the
all-windows-highlighting-ex-search
branch
from
f94cb2c to
50f7d48
Compare
ChoppinBlockParty
force-pushed
the
all-windows-highlighting-ex-search
branch
2 times, most recently
from
aa78a71 to
8c871f1
Compare
Provide a pilot version as PoC. No cross-buffer highlighting for substitution in this version. On the way improve overall performance of highlighting by removing `run-at-time` and introducing `window-end` with `update` equal `t`.
ChoppinBlockParty
force-pushed
the
all-windows-highlighting-ex-search
branch
from
8c871f1 to
e03c0ea
Compare
Author
|
Hello Guys, I have been using this one for more than a year it is working well. Can we consider merging it? |
Member
|
Sorry. :-) I'll have a look this week hopefully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide a pilot version as PoC.
No cross-buffer highlighting for substitution in this version.
On the way improve overall performance of highlighting
by removing
run-at-timeand introducingwindow-endwith
updateequalt.Search pattern in Vim is highlighted in every visible buffer, this does not sound like a big deal, however it is very useful in many small situations. This feature is also addressed in issue #805.
Please, try it out, feedback is highly appreciated. I have tested it quickly on few buffers with some large content as well (like ~20k) worked well, I think the previous version with timer was lagging much more. After some feedback and a few days of real life testing, I will polish this one to be ready for merge.