Skip to content

chore: Bump haskell grammar #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Bump haskell grammar #604

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 12, 2024

No description provided.

@jcs090218 jcs090218 closed this May 12, 2024
@jcs090218 jcs090218 reopened this May 12, 2024
@jcs090218 jcs090218 closed this May 20, 2024
@jcs090218 jcs090218 reopened this May 20, 2024
@jcs090218 jcs090218 closed this May 26, 2024
@jcs090218 jcs090218 reopened this May 26, 2024
@jcs090218 jcs090218 closed this Jun 16, 2024
@jcs090218 jcs090218 reopened this Jun 16, 2024
@github-actions github-actions bot force-pushed the bump-haskell branch 2 times, most recently from 567ecb7 to 5319bb6 Compare July 21, 2024 01:40
@github-actions github-actions bot force-pushed the bump-haskell branch 2 times, most recently from de7284f to f0f305e Compare August 18, 2024 01:41
@jcs090218 jcs090218 closed this Aug 19, 2024
@jcs090218 jcs090218 reopened this Aug 19, 2024
@github-actions github-actions bot force-pushed the bump-haskell branch 2 times, most recently from 2cee856 to 1b026a7 Compare September 8, 2024 01:48
@liesnikov
Copy link

As of now, I'm not seeing any errors when I compile it locally, it looks like it passes on the ci too: https://github.com/liesnikov/tree-sitter-langs/actions/runs/15485334391/job/43599147943#step:13:148

@liesnikov
Copy link

I am not sure what happened with CI, but I'm not seeing any action runs on bump-haskell branch in this repo

@jcs090218 jcs090218 closed this Jun 6, 2025
@jcs090218 jcs090218 reopened this Jun 6, 2025
@liesnikov
Copy link

ah, it needs a toggle. Thanks!
Let's see what it says now

@liesnikov
Copy link

liesnikov commented Jun 6, 2025

Hmm, it seems like the tests aren't stable.
The fail is in queries/haskell for all four failing runs. The run in my repo on the same rev for ubuntu 24.04 28.2 succeeded (I cancelled the others), while here the exact same one failed.

 Test queries/haskell backtrace:
  tsc--make-query(#<user-ptr ptr=0x7f6d699ae760 finalizer=0x7f6d6c3241
  tsc-make-query(#<user-ptr ptr=0x7f6d699ae760 finalizer=0x7f6d6c32415
  (let ((language (tree-sitter-require lang-symbol)) (patterns (tree-s
  tree-sitter-langs-tests-check-queries(haskell)
  (let ((lexical-binding nil)) (let* ((fn-137 #'not) (args-138 (condit
  (lambda nil (let ((lexical-binding nil)) (let* ((fn-137 #'not) (args
  ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
  ert-run-test(#s(ert-test :name queries/haskell :documentation nil :b
  ert-run-or-rerun-test(#s(ert--stats :selector t :tests [... ... ... 
  ert-run-tests(t #f(compiled-function (event-type &rest event-args) #
  ert-run-tests-batch(nil)
  ert-run-tests-batch-and-exit(nil)
  eval((ert-run-tests-batch-and-exit nil) t)
  command-line-1(("-l" "/home/runner/eask-snapshot/lisp/core/emacs.el"
  command-line()
  normal-top-level()
Test queries/haskell condition:
    (tsc-query-invalid-node-type "exp_negation"
				 (5 . 1)
				 126)

@jcs090218
Copy link
Member

It seems like it can be compiled on aarch64 but not on x64. 🤔

@liesnikov
Copy link

liesnikov commented Jun 6, 2025

edit: wait, nevermind, I was confused about the runs - you are right and the x64 runs also failed there

If you look at the CI run in this repo this seems to be the differentiating factor. But it wouldn't explain why the one in my repo succeeded - that run is on x64 and it did succeed.
It was triggered manually, but I don't see anything in the action file where that would make a difference.

@liesnikov
Copy link

Not sure how to make sense of the local succeeding tests though.
I am on Debian 12 with x86_64 CPU, the project shell with dependencies was constructed via nix.

@jcs090218
Copy link
Member

My best guess is that the environment differs slightly—either due to Nix or GitHub Actions. 🤔

@github-actions github-actions bot force-pushed the bump-haskell branch 2 times, most recently from c8fa53f to 4e0c8f4 Compare June 22, 2025 02:23
@jcs090218 jcs090218 closed this Jun 29, 2025
@jcs090218 jcs090218 reopened this Jun 29, 2025
@github-actions github-actions bot force-pushed the bump-haskell branch 2 times, most recently from 8d38a24 to 735792f Compare July 6, 2025 08:31
@jcs090218 jcs090218 closed this Jul 7, 2025
@jcs090218 jcs090218 reopened this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants