fix(annotation/vue): call onClick handler on link pointerdown#517
Merged
bobsingor merged 3 commits intoembedpdf:mainfrom Mar 17, 2026
Merged
fix(annotation/vue): call onClick handler on link pointerdown#517bobsingor merged 3 commits intoembedpdf:mainfrom
bobsingor merged 3 commits intoembedpdf:mainfrom
Conversation
The Vue template `@pointerdown="hasIRT ? undefined : onClick"` compiles
to `($event) => hasIRT ? void 0 : onClick`, which evaluates the onClick
function reference but never calls it. This means clicking a link
annotation in the Vue build never triggers selectOverride, so
selectAnnotation is never called and link selection does not work.
Change to `onClick?.($event)` so Vue compiles it to
`($event) => hasIRT ? void 0 : onClick?.($event)`, which properly
invokes the handler.
The Preact/React builds are unaffected as JSX `onPointerDown={onClick}`
directly assigns the handler reference.
|
@sebabal is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@pointerdown="hasIRT ? undefined : onClick"compiles to($event) => hasIRT ? void 0 : onClick, which returns theonClickfunction reference instead of calling itselectOverride, soselectAnnotationis never called and link selection/navigation does not workonClick?.($event)so Vue properly invokes the handlerThe Preact/React builds are unaffected since JSX
onPointerDown={onClick}directly assigns the handler reference.