Skip to content

Commit 1fc75be

Browse files
committed
Avoid crashing the playground app
1 parent aa1afac commit 1fc75be

File tree

2 files changed

+8
-13
lines changed

2 files changed

+8
-13
lines changed

tests/dummy/app/components/page-title-pane/component.js

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,18 @@ export default Component.extend({
88

99
titleList: service(),
1010

11-
lastIndex: computed('titleList.{sortedTokens.length,tokens.length}', {
11+
lastIndex: computed('titleList.{tokens.length}', {
1212
get() {
13-
return this.titleList.sortedTokens.length - 1;
13+
return this.titleList.tokens.length - 1;
1414
},
1515
}),
1616

1717
actions: {
1818
highlight(token) {
19-
let sortedTokens = A(this.titleList.sortedTokens);
19+
let tokens = A(this.titleList.tokens);
2020
let wasActive = token.active;
21-
this.titleList.tokens.setEach('active', false);
22-
sortedTokens.setEach('active', false);
23-
24-
if (!wasActive) {
25-
set(sortedTokens.findBy('id', token.id), 'active', true);
26-
set(token, 'active', true);
27-
}
21+
tokens.setEach('active', false);
22+
set(token, 'active', !wasActive);
2823
},
2924
},
3025
});

tests/dummy/app/components/page-title-pane/nested-template/component.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ export default Component.extend({
77
classNames: ['nested-template'],
88
classNameBindings: ['active:active'],
99

10-
active: computed('titleList.{sortedTokens,tokens.@each.active}', 'token.id', {
10+
active: computed('titleList.{tokens.@each.active}', 'token.id', {
1111
get() {
12-
let sortedTokens = A(this.titleList.sortedTokens);
13-
let token = sortedTokens.findBy('id', this.token.id);
12+
let tokens = A(this.titleList.tokens);
13+
let token = tokens.findBy('id', this.token.id);
1414
return token && token.active;
1515
},
1616
}),

0 commit comments

Comments
 (0)