Skip to content

Commit 414d37f

Browse files
authored
Merge pull request #926 from ember-fastboot/fix-linting
make sure that we lint (relevant) test-packages
2 parents ddbfeb3 + 06aa8d7 commit 414d37f

File tree

6 files changed

+21
-4
lines changed

6 files changed

+21
-4
lines changed

.editorconfig

+19
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# EditorConfig helps developers define and maintain consistent
2+
# coding styles between different editors and IDEs
3+
# editorconfig.org
4+
5+
root = true
6+
7+
[*]
8+
end_of_line = lf
9+
charset = utf-8
10+
trim_trailing_whitespace = true
11+
insert_final_newline = true
12+
indent_style = space
13+
indent_size = 2
14+
15+
[*.hbs]
16+
insert_final_newline = false
17+
18+
[*.{diff,md}]
19+
trim_trailing_whitespace = false

.github/workflows/ci.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
node-version: ${{ matrix.node-version }}
3535
cache: pnpm
3636
- run: pnpm install --frozen-lockfile
37-
- run: pnpm --filter "./packages/*" lint
37+
- run: pnpm lint
3838

3939
test-all-packages:
4040
name: Ember Tests

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"url": "git@github.com:ember-fastboot/ember-cli-fastboot.git"
77
},
88
"scripts": {
9+
"lint": "pnpm --filter './*packages/**' lint",
910
"test": "npm-run-all test:*",
1011
"test:ember-cli-fastboot": "pnpm --filter ember-cli-fastboot test:ember",
1112
"test:fastboot": "pnpm --filter fastboot test",

test-packages/basic-app/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
"scripts": {
1414
"build": "ember build",
1515
"build:prod": "ember build --environment=production",
16-
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
1716
"lint:hbs": "ember-template-lint .",
1817
"lint:js": "eslint .",
1918
"start": "ember serve",

test-packages/custom-fastboot-app/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
"scripts": {
1414
"build": "ember build",
1515
"build:prod": "ember build --environment=production",
16-
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
1716
"lint:hbs": "ember-template-lint .",
1817
"lint:js": "eslint .",
1918
"start": "ember serve",

test-packages/custom-sandbox-app/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
},
1313
"scripts": {
1414
"build": "ember build --environment=production",
15-
"lint": "npm-run-all --aggregate-output --continue-on-error --parallel lint:*",
1615
"lint:hbs": "ember-template-lint .",
1716
"lint:js": "eslint .",
1817
"start": "ember serve",

0 commit comments

Comments
 (0)