Merge pull request #920 from ember-fastboot/linting

Add Linting to CI

Author: mansona

.github/workflows/ci.yml

@@ -19,6 +19,23 @@ on:
   - cron:  '0 6 * * 0'
 
 jobs:
+  lint-all-packages:
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
+        with:
+          version: 7
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: pnpm
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm --filter "./packages/*" lint
+
   test-all-packages:
     name: Ember Tests
     runs-on: ${{ matrix.os }}

.gitignore

@@ -16,6 +16,7 @@ node_modules/
 /npm-debug.log*
 /testem.log
 yarn-error.log
+.eslintcache
 
 # ember-try
 .node_modules.ember-try/

packages/ember-cli-fastboot/.eslintrc.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-dupe-keys, prettier/prettier */
 'use strict';
 
 module.exports = {

packages/ember-cli-fastboot/addon/instance-initializers/clear-double-boot.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 // When using `ember serve` when fastboot addon is installed the application
 // output will already be rendered to the DOM when the actual JavaScript
 // loads. Ember does not automatically clear its `rootElement` so this

packages/ember-cli-fastboot/addon/locations/none.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/no-classic-classes, ember/no-get, ember/require-computed-property-dependencies, prettier/prettier */
 import { computed, get } from '@ember/object';
 import { bool, readOnly } from '@ember/object/computed';
 import { inject as service } from '@ember/service';

packages/ember-cli-fastboot/addon/services/fastboot.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/no-classic-classes, ember/no-get, ember/require-computed-property-dependencies, ember/require-return-from-computed, prettier/prettier */
 /* global FastBoot */
 import { getOwner } from '@ember/application';
 import { computed, get } from '@ember/object';

packages/ember-cli-fastboot/blueprints/ember-cli-fastboot/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 /* eslint-env node */
 const recast = require('recast');
 const { readFileSync, writeFileSync } = require('fs');

packages/ember-cli-fastboot/fastboot-app-lt-2-9/initializers/dom-helper-patches.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-redeclare, no-unused-vars, prettier/prettier */
 /*globals Ember, URL*/
 export default {
   name: "dom-helper-patches",

packages/ember-cli-fastboot/fastboot/initializers/ajax.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 /* globals najax */
 import Ember from 'ember';
 

packages/ember-cli-fastboot/fastboot/initializers/error-handler.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 import Ember from 'ember';
 
 /**

packages/ember-cli-fastboot/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-prototype-builtins, prettier/prettier */
 /* eslint-env node */
 'use strict';
 

packages/ember-cli-fastboot/lib/broccoli/fastboot-config.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef, prettier/prettier */
 /* eslint-env node */
 'use strict';
 

packages/ember-cli-fastboot/lib/build-utilities/migrate-initializers.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 'use strict';
 
 const path = require('path');

packages/ember-cli-fastboot/lib/utilities/fastboot-app-boot.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 'use strict'
 
 // Added as app boot code to app.js that allows booting of the application

packages/ember-cli-fastboot/lib/utilities/fastboot-app-factory-module.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 'use strict';
 
 // Expose an factory for the creating the `Application` object

packages/ember-cli-fastboot/package.json

@@ -88,6 +88,8 @@
     "eslint-plugin-node": "^11.1.0",
     "eslint-plugin-prettier": "^3.3.1",
     "glob": "^7.1.3",
+    "lint-to-the-future": "^2.0.0",
+    "lint-to-the-future-eslint": "^2.0.1",
     "loader.js": "^4.7.0",
     "mocha": "^9.1.2",
     "npm-run-all": "^4.1.5",

packages/ember-cli-fastboot/test/fastboot-config-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const expect = require('chai').use(require('chai-string')).expect;

packages/ember-cli-fastboot/test/fastboot-location-config-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const expect = require('chai').expect;

packages/ember-cli-fastboot/test/fastboot-location-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef, prettier/prettier */
 'use strict';
 
 const expect = require('chai').expect;

packages/ember-cli-fastboot/test/fixtures/customized-outputpaths/config/targets.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const browsers = [

packages/ember-cli-fastboot/test/fixtures/customized-outputpaths/ember-cli-build.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-redeclare, prettier/prettier */
 /*jshint node:true*/
 /* global require, module */
 var EmberApp = require('ember-cli/lib/broccoli/ember-app');

packages/ember-cli-fastboot/test/fixtures/fastboot-config/app/router.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 import config from './config/environment';
 

packages/ember-cli-fastboot/test/fixtures/fastboot-config/app/routes/application.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/fastboot-config/config/environment.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 /* jshint node: true */
 'use strict';
 

packages/ember-cli-fastboot/test/fixtures/fastboot-config/config/fastboot.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef, no-unused-vars, prettier/prettier */
 module.exports = function(environment) {
   return {
     sandboxGlobals: {

packages/ember-cli-fastboot/test/fixtures/fastboot-config/config/targets.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const browsers = [

packages/ember-cli-fastboot/test/fixtures/fastboot-config/ember-cli-build.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 module.exports = function(defaults) {
   var EmberApp = require('ember-cli/lib/broccoli/ember-app');
   var app = new EmberApp(defaults, {});

packages/ember-cli-fastboot/test/fixtures/fastboot-location-config/app/router.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 let Router = Ember.Router;

packages/ember-cli-fastboot/test/fixtures/fastboot-location-config/app/routes/redirect-on-transition-to.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/fastboot-location-config/app/routes/test-passed.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports */
 import Ember from 'ember';
 
 export default Ember.Route.extend({});

packages/ember-cli-fastboot/test/fixtures/fastboot-location-config/config/environment.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef, prettier/prettier */
 'use strict';
 
 module.exports = function(environment) {

packages/ember-cli-fastboot/test/fixtures/fastboot-location-config/config/targets.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const browsers = [

packages/ember-cli-fastboot/test/fixtures/fastboot-location/app/router.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 import config from './config/environment';
 

packages/ember-cli-fastboot/test/fixtures/fastboot-location/app/routes/noop-replace-with.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/fastboot-location/app/routes/noop-transition-to.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/fastboot-location/app/routes/redirect-on-intermediate-transition-to.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/fastboot-location/app/routes/redirect-on-replace-with.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/fastboot-location/app/routes/redirect-on-transition-to.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/fastboot-location/app/routes/test-passed.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports */
 import Ember from 'ember';
 
 export default Ember.Route.extend({});

packages/ember-cli-fastboot/test/fixtures/fastboot-location/config/environment.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef, prettier/prettier */
 'use strict';
 
 module.exports = function(environment) {

packages/ember-cli-fastboot/test/fixtures/fastboot-location/config/targets.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const browsers = [

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/list-cookies.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/list-headers.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/list-query-params.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/show-body.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/show-host.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/show-method.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/show-path.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/controllers/show-protocol.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Controller.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/list-cookies.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-cookies',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/list-headers.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-headers',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/list-query-params.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-query-params',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/show-body.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-boy',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/show-host.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-host',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/show-method.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-method',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/show-path.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-path',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/instance-initializers/show-protocol.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 export default {
   name: 'test-protocol',
   initialize(applicationInstance) {

packages/ember-cli-fastboot/test/fixtures/request/app/router.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 import Ember from 'ember';
 import config from './config/environment';
 

packages/ember-cli-fastboot/test/fixtures/request/app/routes/list-cookies.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from "ember";
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/routes/list-headers.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/routes/list-query-params.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/routes/show-body.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/routes/show-host.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/routes/show-method.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/routes/show-path.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/app/routes/show-protocol.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, ember/no-get, prettier/prettier */
 import Ember from 'ember';
 
 export default Ember.Route.extend({

packages/ember-cli-fastboot/test/fixtures/request/config/environment.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 /* jshint node: true */
 'use strict';
 

packages/ember-cli-fastboot/test/fixtures/request/config/targets.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const browsers = [

packages/ember-cli-fastboot/test/fixtures/request/lib/post-middleware/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable node/no-extraneous-require, prettier/prettier */
 var bodyParser = require('body-parser');
 var FastBootExpressMiddleware = require('fastboot-express-middleware');
 var FastBoot = require('fastboot');

packages/ember-cli-fastboot/test/fixtures/root-url/config/environment.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef, prettier/prettier */
 'use strict';
 
 module.exports = function(environment) {

packages/ember-cli-fastboot/test/fixtures/root-url/config/targets.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const browsers = [

packages/ember-cli-fastboot/test/new-package-json-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef, prettier/prettier */
 /* eslint-env node */
 'use strict';
 

packages/ember-cli-fastboot/test/package-json-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const chai = require('chai');

packages/ember-cli-fastboot/test/request-details-test.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-undef */
 'use strict';
 
 const chai = require('chai');