Merge pull request #920 from ember-fastboot/linting

Add Linting to CI

Author: mansona

.github/workflows/ci.yml

@@ -19,6 +19,23 @@ on:
   - cron:  '0 6 * * 0'
 
 jobs:
+  lint-all-packages:
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+
+    steps:
+      - uses: actions/checkout@v3
+      - uses: pnpm/action-setup@v2
+        with:
+          version: 7
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v3
+        with:
+          node-version: ${{ matrix.node-version }}
+          cache: pnpm
+      - run: pnpm install --frozen-lockfile
+      - run: pnpm --filter "./packages/*" lint
+
   test-all-packages:
     name: Ember Tests
     runs-on: ${{ matrix.os }}

.gitignore

@@ -16,6 +16,7 @@ node_modules/
 /npm-debug.log*
 /testem.log
 yarn-error.log
+.eslintcache
 
 # ember-try
 .node_modules.ember-try/

packages/ember-cli-fastboot/.eslintrc.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-dupe-keys, prettier/prettier */
 'use strict';
 
 module.exports = {

packages/ember-cli-fastboot/addon/instance-initializers/clear-double-boot.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 // When using `ember serve` when fastboot addon is installed the application
 // output will already be rendered to the DOM when the actual JavaScript
 // loads. Ember does not automatically clear its `rootElement` so this

packages/ember-cli-fastboot/addon/locations/none.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/no-classic-classes, ember/no-get, ember/require-computed-property-dependencies, prettier/prettier */
 import { computed, get } from '@ember/object';
 import { bool, readOnly } from '@ember/object/computed';
 import { inject as service } from '@ember/service';

packages/ember-cli-fastboot/addon/services/fastboot.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/no-classic-classes, ember/no-get, ember/require-computed-property-dependencies, ember/require-return-from-computed, prettier/prettier */
 /* global FastBoot */
 import { getOwner } from '@ember/application';
 import { computed, get } from '@ember/object';

packages/ember-cli-fastboot/blueprints/ember-cli-fastboot/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 /* eslint-env node */
 const recast = require('recast');
 const { readFileSync, writeFileSync } = require('fs');

packages/ember-cli-fastboot/fastboot-app-lt-2-9/initializers/dom-helper-patches.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-redeclare, no-unused-vars, prettier/prettier */
 /*globals Ember, URL*/
 export default {
   name: "dom-helper-patches",

packages/ember-cli-fastboot/fastboot/initializers/ajax.js

@@ -1,3 +1,4 @@
+/* eslint-disable ember/new-module-imports, prettier/prettier */
 /* globals najax */
 import Ember from 'ember';
 

packages/ember-cli-fastboot/fastboot/initializers/error-handler.js

@@ -1,3 +1,4 @@
+/* eslint-disable prettier/prettier */
 import Ember from 'ember';
 
 /**