Use this to prevent memory leak of application instance #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bobisjan
commented
Aug 8, 2018
bobisjan
commented
snewcomer
reviewed
Nov 13, 2018
| @@ -29,7 +29,7 @@ export default { | |||
|
|
|||
| instance.didCreateRootView = function() { | |||
| clearHtml(); | |||
| originalDidCreateRootView.apply(instance, arguments); | |||
| originalDidCreateRootView.apply(this, arguments); | |||
There was a problem hiding this comment.
@bobisjan Do you still have this issue? Is this due to babel transpilation? i.e. what happens if we convert the function to arrow syntax so it operates in the context of the enclosing scope?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.