Skip to content

Commit 62171d5

Browse files
committed
remove ember-fetch
1 parent d01d4e7 commit 62171d5

File tree

4 files changed

+525
-514
lines changed

4 files changed

+525
-514
lines changed

addon/services/apollo.js

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { get, set, setProperties, defineProperty } from '@ember/object';
22
import { sendEvent } from '@ember/object/events';
33
import RSVP from 'rsvp';
44
import Service from '@ember/service';
5-
import fetch from 'fetch';
65
import { A } from '@ember/array';
76
import {
87
ApolloClient,
@@ -14,7 +13,7 @@ import { isArray } from '@ember/array';
1413
import { isNone, isPresent } from '@ember/utils';
1514
import { run, next } from '@ember/runloop';
1615
import { QueryManager } from '../index';
17-
import { waitForPromise } from '@ember/test-waiters';
16+
import { waitForFetch } from '@ember/test-waiters';
1817
import { tracked } from '@glimmer/tracking';
1918
import { macroCondition, isTesting } from '@embroider/macros';
2019

@@ -185,7 +184,7 @@ export default class ApolloService extends Service {
185184
* @public
186185
*/
187186
mutate(opts, resultKey) {
188-
return waitForPromise(
187+
return waitForFetch(
189188
new RSVP.Promise((resolve, reject) => {
190189
this.client
191190
.mutate(opts)
@@ -235,7 +234,7 @@ export default class ApolloService extends Service {
235234
subscription && subscription.unsubscribe();
236235
}
237236

238-
return waitForPromise(
237+
return waitForFetch(
239238
new RSVP.Promise((resolve, reject) => {
240239
// TODO: add an error function here for handling errors
241240
subscription = observable.subscribe({
@@ -267,7 +266,7 @@ export default class ApolloService extends Service {
267266

268267
const obj = new EmberApolloSubscription();
269268

270-
return waitForPromise(
269+
return waitForFetch(
271270
new RSVP.Promise((resolve, reject) => {
272271
let subscription = observable.subscribe({
273272
next: (newData) => {
@@ -302,7 +301,7 @@ export default class ApolloService extends Service {
302301
* @public
303302
*/
304303
query(opts, resultKey) {
305-
return waitForPromise(
304+
return waitForFetch(
306305
new RSVP.Promise((resolve, reject) => {
307306
this.client
308307
.query(opts)
@@ -353,7 +352,7 @@ export default class ApolloService extends Service {
353352
subscription && subscription.unsubscribe();
354353
}
355354

356-
return waitForPromise(
355+
return waitForFetch(
357356
new RSVP.Promise((resolve, reject) => {
358357
subscription = observable.subscribe({
359358
next: newDataFunc(observable, resultKey, resolve, unsubscribe),

package.json

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,8 @@
3939
"dependencies": {
4040
"@apollo/client": "^3.5.10",
4141
"@ember/string": "^3.1.1",
42-
"@ember/test-waiters": "~3.0.1",
43-
"@embroider/macros": "^1.5.0",
42+
"@ember/test-waiters": "^4.1.0",
43+
"@embroider/macros": "^1.18.0",
4444
"@glimmer/tracking": "^1.1.2",
4545
"broccoli-graphql-filter": "^1.0.0",
4646
"ember-auto-import": "^2.4.3",
@@ -49,7 +49,7 @@
4949
"devDependencies": {
5050
"@babel/core": "^7.17.7",
5151
"@ember/optional-features": "^2.0.0",
52-
"@ember/test-helpers": "^2.8.1",
52+
"@ember/test-helpers": "^4.0.4",
5353
"@embroider/test-setup": "^1.8.3",
5454
"@glimmer/component": "^1.1.2",
5555
"babel-eslint": "^10.1.0",
@@ -61,10 +61,9 @@
6161
"ember-cli-terser": "^4.0.2",
6262
"ember-compatibility-helpers": "^1.2.6",
6363
"ember-disable-prototype-extensions": "^1.1.3",
64-
"ember-fetch": "^8.1.1",
6564
"ember-load-initializers": "^2.1.2",
6665
"ember-page-title": "^7.0.0",
67-
"ember-qunit": "^6.0.0",
66+
"ember-qunit": "^8.1.1",
6867
"ember-resolver": "^8.0.3",
6968
"ember-source": "~4.8.0",
7069
"ember-source-channel-url": "^3.0.0",

testem.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
module.exports = {
44
test_page: 'tests/index.html?hidepassed',
5+
framework: 'qunit',
56
disable_watching: true,
67
client_decycle_depth: 10,
78
launch_in_ci: ['Chrome'],

0 commit comments

Comments
 (0)