-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[FEATURE] Add a --route-authoring-format
option to the route generator
#20835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[FEATURE] Add a --route-authoring-format
option to the route generator
#20835
Conversation
14cad41
to
9a0a990
Compare
I've added this to the agenda for us to discuss a name on tuesday. thanks for working on this!!! |
9a0a990
to
975bd95
Compare
--strict-template
option to the route generator--strict-route-template
option to the route generator
975bd95
to
770cc30
Compare
--strict-route-template
option to the route generator--route-authoring-format
option to the route generator
--route-authoring-format
option to the route generator--route-authoring-format
option to the route generator
--route-authoring-format
option to the route generator--route-authoring-format
option to the route generator
blueprints/route/files/__root__/__templatepath__/__templatename__.gts
Outdated
Show resolved
Hide resolved
I'm 👍 but this will need rebasing after #20862 lands |
there are no conflicts -- why rebase? 🤔 |
Yea, there are indeed conflicts, and there are also some other things I need to adjust (.gts tests, more types, ...). I need to find some time to look into it again. |
770cc30
to
379832d
Compare
Development AssetsDiff Details
|
4fcdd2a
to
93e5e9a
Compare
model: unknown; | ||
controller: unknown; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I matched what the template-tag codemod outputs.
This allows users to generate .gjs/.gts templates instead of .hbs templates.
93e5e9a
to
d38d1a7
Compare
Now that #20800 is merged, it would also be nice if we could generate new routes with a .gjs / .gts template already.
or the shorthand:
or as the project's default by adding
routeAuthoringFormat: 'strict'
in .ember-cliCurrent status
Ready to review!