-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[BUGFIX beta] Fix the Embroider smoke tests #20897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pins the Embroider packages to the latest version the smoke test app supports without code changes. The new releases only support Vite.
89067db
to
9ab7374
Compare
Development AssetsDiff Details
|
NullVoxPopuli
approved these changes
Apr 28, 2025
I'll merge this to unblock CI but I think this somewhat guts the point of the smoke tests. Thoughts @ef4? |
yea step next would be "use vite" could even try the vite codemod |
I don't think this defeats the point of the tests. We just need to expand the scenarios. Currently there are scenarios for classic and for Embroider 3.x. We need a 4.x scenario too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pins the Embroider packages to the latest version the smoke test app supports without code changes. The new releases only support Vite.