fix: get_shape() -> shape attribute for CSC matrices/arrays
#57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi! I'm not sure if this is intended, but using `get_shape` only works for [`csc_matrix`](https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.csc_matrix.html), but not [`csc_array`](https://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.csc_array.html), which raises an error when passing a sparse array as input. I encountered this bug when using the CVXPYLayers, and I could not find any issue related to this error (i.e., the fact that `csc_array` doesn't have a `get_shape` method). If you intend to support both `csc_matrix` and `csc_array`, then using `.shape` works like a charm. Otherwise, I think it would be good to add another check before, as `csc_array.to_csc()` returns a `csc_array`, and not a `csc_matrix` as expected by the `if` guard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I'm not sure if this is intended, but using
get_shapeonly works forcsc_matrix, but notcsc_array, which raises an error when passing a sparse array as input. I encountered this bug when using the CVXPYLayers, and I could not find any issue related to this error (i.e., the fact thatcsc_arraydoesn't have aget_shapemethod).If you intend to support both
csc_matrixandcsc_array, then using.shapeworks like a charm.Otherwise, I think it would be good to add another check before, as
csc_array.to_csc()returns acsc_array, and not acsc_matrixas expected by theifguard.