Skip to content

Commit 5995b67

Browse files
pierrreemersion
authored andcommitted
dkim: compare with strings.EqualFold instead of ToLower
It doesn't allocate a new string each time. Fixes #48
1 parent e98a2ee commit 5995b67

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

dkim/header.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,13 +149,12 @@ func newHeaderPicker(h header) *headerPicker {
149149
}
150150

151151
func (p *headerPicker) Pick(key string) string {
152-
key = strings.ToLower(key)
153152
at := p.picked[key]
154153
for i := len(p.h) - 1; i >= 0; i-- {
155154
kv := p.h[i]
156155
k, _ := parseHeaderField(kv)
157156

158-
if strings.ToLower(k) != key {
157+
if !strings.EqualFold(k, key) {
159158
continue
160159
}
161160

dkim/verify.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,7 @@ func verify(h header, r io.Reader, sigField, sigValue string, options *VerifyOpt
241241
headerKeys := parseTagList(params["h"])
242242
ok := false
243243
for _, k := range headerKeys {
244-
if strings.ToLower(k) == "from" {
244+
if strings.EqualFold(k, "from") {
245245
ok = true
246246
break
247247
}

0 commit comments

Comments
 (0)