Skip ldd check on ARM Linux #625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the commonly used glibc hack-patch enables kodi on ARM Linux to use the ChromeOS widevine library ldd will still correctly fail with an error message because of the missing GLIBC_ABI_DT_RELR dependency. This makes the test quite useless on ARM, results in repeated logspam and the logged error may also be misleading to users. Signed-off-by: Matthias Reichl <hias@horus.com>
HiassofT
force-pushed
the
ldd-skip-arm
branch
from
bfa22f7 to
a503965
Compare
|
|
Thanks for this contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the commonly used glibc hack-patch enables kodi on ARM Linux to use the ChromeOS widevine library ldd will still correctly fail with an error message because of the missing GLIBC_ABI_DT_RELR dependency.
This makes the test quite useless on ARM, results in repeated logspam and the logged error may also be misleading to users.