Skip to content

Adds SDL3_image port #24634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

fredheidrich
Copy link

No description provided.

Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks generally good.

Removes duplicated tests that are already done in SDL2 (wasmfs, sjlj & co)

Co-authored-by: Alon Zakai <alonzakai@gmail.com>
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but is this still marked as draft because you have more work to do?

@kripken
Copy link
Member

kripken commented Jul 2, 2025

Code size test failures should be fixed by merging in latest main.

The documentation test error should be fixable by the command mentioned in the error, Please run tools/maint/update_settings_docs.py

@kripken
Copy link
Member

kripken commented Jul 2, 2025

Oh, please add a changelog mention here too, as in the other PR.

Thanks, it's great to get these added!

@fredheidrich
Copy link
Author

lgtm, but is this still marked as draft because you have more work to do?

That's right, wanted to fix the failing doctest first -- will do that asap, thank you :)

printf("you should see an image.\n");

return result;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this file differ from test_sdl2_image.c? If not much, it might be worth using the same file?

Copy link
Author

@fredheidrich fredheidrich Jul 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, the API has changed slightly from 2->3. It certainly possibly to pass the differences from the test suite but that would likely make the code a bit confusing to read (imho).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the differences? Or maybe just attach a diff of test_sdl2_image.c and test_sdl3_image.c?

@fredheidrich fredheidrich marked this pull request as ready for review July 13, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants