Skip to content

Fix unresolved symbol in standalone debug build. #24680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Fix unresolved symbol in standalone debug build. #24680

merged 2 commits into from
Jul 14, 2025

Conversation

vchigrin
Copy link
Contributor

Ensure WASM binaries, produced in standalone debug mode, does not require __throw_exception_with_stack_trace function. In non-standalone mode it implemented in JS.

@vchigrin
Copy link
Contributor Author

Guess new behavior is desirable based on this reply
#19150 (comment)
particluary, sentence
"That shouldn't be emitted in standalone mode, so we should add an if to remove that. "

@sbc100
Copy link
Collaborator

sbc100 commented Jul 10, 2025

Perhaps we could add a test for this?

Perhaps you could update the existing test_f_exception in test_other.py it looks like it already has a standalone version of that test

@vchigrin
Copy link
Contributor Author

vchigrin commented Jul 11, 2025 •
edited
Loading

Added a test - I found that separate test for this scenario looks better then integrating it into test_f_exception.
Checked that new test fails without first commit and passes with it.

sbc100
sbc100 approved these changes Jul 11, 2025
View reviewed changes
@vchigrin vchigrin force-pushed the fix-standalone-debug-build branch from 730e1ef to 7b4831b Compare July 11, 2025 14:56
@sbc100 sbc100 enabled auto-merge (squash) July 11, 2025 15:27
auto-merge was automatically disabled July 14, 2025 08:05

Head branch was pushed to by a user without write access

@vchigrin vchigrin force-pushed the fix-standalone-debug-build branch from 7b4831b to 38c31db Compare July 14, 2025 08:05
@vchigrin
Copy link
Contributor Author

Sorry, last CI run failed with some errors that, I thought, dos not relate to my changes. So I rebased PR on the current main branch - did not realize that it will required manual approve for CI run...

@sbc100 sbc100 merged commit 5b95aa7 into emscripten-core:main Jul 14, 2025
30 checks passed
sbc100 added a commit to sbc100/emscripten that referenced this pull request Jul 14, 2025
@sbc100
Improve test_standalone_imports
d05efcd 
- Run the resulting binary
- Remove redundant -O0

Followup to emscripten-core#24680
@sbc100 sbc100 mentioned this pull request Jul 14, 2025
Merged
sbc100 added a commit that referenced this pull request Jul 14, 2025
@sbc100
Improve test_standalone_imports (#24696)
e357360 
- Run the resulting binary
- Remove redundant -O0

Followup to #24680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchigrin @sbc100