-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Enable growable array buffers #24684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
IIUC, we could also conditionally exclude these two behind emscripten/system/lib/standalone/standalone.c Lines 133 to 136 in 8f12acf
Lines 2418 to 2424 in 8f12acf
|
Yeah.. I thought of doing that, but didn't want to create yet another library variant. But I think it might be worth it. |
c3ba09b
to
50c7d06
Compare
Done! |
856b5d2
to
2608cc4
Compare
Added a new test |
Currently this is still behind a flag so we never turn it on by default. Fixes: emscripten-core#24287
'proxy': (['-sPROXY_TO_PTHREAD', '-sEXIT_RUNTIME'], 2), | ||
}) | ||
def test_pthread_growth_mainthread(self, cflags, pthread_pool_size): | ||
if '-sGROWABLE_ARRAYBUFFERS' in cflags: | ||
self.node_args.append('--experimental-wasm-rab-integration') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth appending to v8_args too, like we do for other experimental features?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
This change should be good to go now. PTAL |
self.node_args.append('--experimental-wasm-rab-integration') | ||
self.require_node_canary() | ||
else: | ||
self.cflags.append('-Wno-pthreads-mem-growth') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd keep this inline in the original flags, after all if that warning shows up in "growable array buffer" mode, we also want the test to error out as it would be unexpected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a nitpick, but otherwise very exciting!
Currently this is still behind a flag so we never turn it on by default.
Fixes: #24287