Skip to content

Remove closure compile hack when running npm ci #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Remove closure compile hack when running npm ci #1541

merged 1 commit into from
Mar 25, 2025

Conversation

sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Mar 25, 2025

@sbc100 sbc100 requested review from juj and dschuff March 25, 2025 18:09
@sbc100 sbc100 enabled auto-merge (squash) March 25, 2025 18:39
@sbc100 sbc100 merged commit 7c8f0a2 into main Mar 25, 2025
9 checks passed
@sbc100 sbc100 deleted the npm_issue branch March 25, 2025 19:39
@juj
Copy link
Collaborator

juj commented Apr 3, 2025

I was verifying this change locally, since this PR results in Java closure compiler no longer being deleted, but it looks like there is an earlier regression with the addition of the bootstrap.py script in Emscripten that masked the size diff.

Before bootstrap.py script, the node_modules\ subdirectory on Windows would read 81.0 MB (85,015,488 bytes) in size.

After addition of bootstrap.py, the subdirectory reads 169 MB (177,525,552 bytes), a 2x increase.

I wrote more details at #1546.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants