Feature suggestions

[karfau]

I have two ideas for additional features.
I'm willing to provide PR's for those if you are interested.

1. add config option to also show the button if no user is curretly logged in.
   My use case is that I have a staging area where the editing happens, and it is OK if users click on the button and need to login first. (On the public live page the login and admin plugin are not installed.)

2. add config option to set custom target for the link
   to prevent opening dozens of tabs

3. add page header/frontmatter option to set custom editUrl to use for the button
   My use case is that e.g. on the "Newsletter" page they actually need to write a mail instead of editing the newsletter page.

What do you think about those ideas and which of them would you like to be part of your plugin?

PS: Having these options would allow me to use your plugin instead of hacking around in my theme ...

[enovision]

@karfau Thank you for your suggestions which are useful for an upcoming release of this plugin.

1. That should not be so hard to implement
2. That could be done how Wordpress is doing this with the preview. Once a preview is already open, it will use that tab to refresh the preview
3. Here I have a question, you mean that you have frontmatter where you can enter a custom URL that should be used as the editing URL. Do you have a sample for me how such a URL could look like.

[karfau]

For 3 I have these use cases:

1. When you think CRUD, on the list page the button would actually link to the page that allows adding an item
2. For sending a newsletter to the subscribed users, the author should not edit the newsletter page but using a mailto: link, it would open her/his mail client

[karfau]

BTW: I have implemented most of this in a hacky way in my fork already.
If you are OK with all of it in one PR I could clean it up and prepare the PR.

If you prefer multiple single purpose PRs (which I can understand) I'm not sure when I will find the time to separate the things and provide the PRs.

[enovision]

@karfau I will have a look at your fork first. Then I will respond back to you.

[karfau]

@enovision I just found out that I didn't push any of my changes to my for yet and that my fork was not up to date. I fixed all that now, you can now have a look at the changes related to this ticket.

Sorry for the wrong information earlier, I hope you didn't invest to much time searching for something that was not available.

[karfau]

Any updates on this topic?