Extract conscrypt native libs from Snowflake and Google_Api #13211
Conversation
Akirathan
changed the title
Akirathan
changed the title
Akirathan
added
CI: No changelog needed
✨ GUI Checks ResultsSummary
See individual check results for more details. |
Akirathan
requested review from
jdunkerley,
radeusgd,
GregoryTravis,
AdRiley,
4e6,
JaroslavTulach and
hubertp
as code owners
hubertp
changed the title
| ) { | ||
| None | ||
| } else { | ||
| val outputArch = validArch.replace("x86_64", "amd64") |
There was a problem hiding this comment.
This is the name of the directory that will be put inside the polyglot/lib/<osname> directory. The expected directory structure inside polyglot/lib is documented in NativeLibraryFinder.
| "META-INF/SIGNINGC.SF", | ||
| "META-INF/SIGNINGC.RSA" | ||
| ) | ||
| val conscryptVersion = "2.5.2" |
There was a problem hiding this comment.
should be provided as a parameter of a function. We don't want to have multiple versions of conscrypt floating around.
There was a problem hiding this comment.
Not sure I agree on this one. As mentioned in the docs for this method, org.constrypt:constrypt-openjdk-uber:2.5.2 is a transitive dependency. It is not directly listed by us anywhere. Besides, if some of our direct dependencies changes version of this transitive dependency, JPMSUtils.filterModulesFromUpdate method call will fail.
There was a problem hiding this comment.
OK. In that case it is still broken. If we upgrade the dependency that brings conscrypt and the former bumps its version, it will only show up when running your test suite (I guess?). Ideally the inference of the version would be automatic.
There was a problem hiding this comment.
it will only show up when running your test suite (I guess?)
This is no "test suite". This is done during buildEngineDistribution. So if anything upgrades the transitive dependency, there will be an early failure - buildEngineDistribution will be failing.
Ideally the inference of the version would be automatic.
Yes, ideally it should. Ideally, sbt should be properly documented and it should expose API for fetching dependencies. But it does not.
Closes #13154
Pull Request Description
Extracts native libraries from
conscrypt-openjdk-uber-2.5.2.jar. This jar is a transitive dependency both withinStandard.SnowlfakeandStandard.Google_Api. This PR extracts the native libs from both these jars.Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.