Why is `pool` not referencing the entity in the `Swap` entity?

[akshatmittal]

Basically title. I noticed the schema doesn't link the pool property to the entity, even though it's referenced in the comment.

I'm wondering why since it would be great to create composite queries referencing pool properties and swaps.

[moose-code]

Correct, I should make a simple reference instead of using the string. Need to do this in a couple places.

[moose-code]

In my initial implementation I had a reason for not doing this, but yes now I should change it 👍

[akshatmittal]

Thanks for the clarification, that makes sense. Early implementations are always scrappy! Will be watching for updates!

(Great indexer btw, planning to use later!)

[moose-code]

@akshatmittal how is it going? Curious to hear updates

[akshatmittal]

Hey @moose-code, I think the indexer still doesn't have the correct entity attached to swaps and what I was doing ended up being much simpler than needing a subgraph so I just wrote a custom indexer. (I believe the indexer is missing daily/hourly data as well, so probably need to fall back to the v4-subgraph indexer for that)