Fix a dns integration test failure issue when run the test in a system does not support IPv6#43465
Merged
yanjunxiang-google merged 5 commits intoenvoyproxy:mainfrom Feb 26, 2026
Merged
Conversation
IPv6 Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
yanjunxiang-google
requested review from
RyanTheOptimist and
mattklein123
as code owners
Contributor
Author
|
/assign @yanavlasov @ravenblackx @adisuissa |
Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
/retest |
…ns_test Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
…ns_test Signed-off-by: Yanjun Xiang <yanjunxiang@google.com>
Contributor
Author
|
Kind Ping! |
ravenblackx
approved these changes
Feb 26, 2026
adisuissa
approved these changes
Feb 26, 2026
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks, overall LGTM!
One thing to consider is adding an integration-test that uses the getAddrInfo actual call to ensure that the invoked system-calls are not causing a bug.
Contributor
Author
Thanks for the comments! |
bmjask
pushed a commit
to bmjask/envoy
that referenced
this pull request
Mar 14, 2026
…m does not support IPv6 (envoyproxy#43465) It is observed that when run "bazel test test/integration:protocol_integration_test" in some computer systems which doesn't support IPv6, the logicalDns and StrictDns tests in the protocol_integration_test.cc fail. The failure reason is that after envoyproxy#39731, the getAddrinfo() syscall will only return IPv4 or IPv6 addresses supported by the local system. As protocol_integration_test.cc is parameterized by IP versioning, i.e, it tests both V4 and V6. So, when it runs V6 test, if the local system does not support V6, the getAddrinfo() syscall will return empty host address list, and Envoy deems there is no healthy upstream available, and sends 503 local reply and test failed. Envoy should not use linux getAddrinfo() syscall in the tests as that leads to indeterministic behavior. The fix is to use mocked getAddrinfo() in these tests. --------- Signed-off-by: Yanjun Xiang <yanjunxiang@google.com> Signed-off-by: bjmask <11672696+bjmask@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is observed that when run "bazel test test/integration:protocol_integration_test" in some computer systems which doesn't support IPv6, the logicalDns and StrictDns tests in the protocol_integration_test.cc fail.
The failure reason is that after #39731, the getAddrinfo() syscall will only return IPv4 or IPv6 addresses supported by the local system. As protocol_integration_test.cc is parameterized by IP versioning, i.e, it tests both V4 and V6. So, when it runs V6 test, if the local system does not support V6, the getAddrinfo() syscall will return empty host address list, and Envoy deems there is no healthy upstream available, and sends 503 local reply and test failed.
Envoy should not use linux getAddrinfo() syscall in the tests as that leads to indeterministic behavior. The fix is to use mocked getAddrinfo() in these tests.