Skip to content

Conversation

@y-rabie
Copy link
Contributor

@y-rabie y-rabie commented Nov 19, 2025

First PR split of #7307. Includes only changes in the gateway-api runner.
E2e tests are included in the second PR.

Signed-off-by: y-rabie <youssef.rabie@procore.com>
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 10.61947% with 202 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.06%. Comparing base (4af9a89) to head (e5e5925).

Files with missing lines Patch % Lines
internal/gatewayapi/runner/runner.go 0.00% 196 Missing ⚠️
internal/gatewayapi/extensionserverpolicy.go 80.00% 2 Missing and 4 partials ⚠️

❌ Your patch check has failed because the patch coverage (10.61%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7557      +/-   ##
==========================================
- Coverage   72.28%   72.06%   -0.22%     
==========================================
  Files         232      232              
  Lines       34152    34289     +137     
==========================================
+ Hits        24688    24712      +24     
- Misses       7684     7796     +112     
- Partials     1780     1781       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arkodg
Copy link
Contributor

arkodg commented Nov 19, 2025

hey @y-rabie I agree with the overall logic here, suggesting improvements in the algo to avoid the nested for loops

  • can replace the .Store with an internal Merge
  • common state can be stored in map with status ptr as values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants