Merged
Conversation
Owner
|
@gitmur444 Sorry that it took me so long to merge it. And thank you for one of the most well-documented PRs I've ever seen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The map-machine currently fails with "Cannot download data" error when trying to download data from the OpenStreetMap API in some environments (particularly Docker containers). This happens because the OSM API returns gzip-compressed responses, but the code in
osm_getter.pyexpects the response to start with an XML opening bracket<.Root Cause
When the OSM API returns compressed (gzip) data, the binary content starts with gzip magic bytes
\x1f\x8binstead of XML's<. This causes map-machine to reject the response as invalid and raise a "Cannot download data" error.Evidence and Logs
With original code, when downloading a larger area:
With the fixed code, we get a proper error for large areas:
And for appropriately sized areas, it works correctly: