Skip to content

Supports #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Supports #14

wants to merge 6 commits into from

Conversation

lelami
Copy link
Contributor

@lelami lelami commented May 13, 2020

No description provided.

l1va
l1va reviewed Aug 5, 2020
View reviewed changes
primitives/triangle.go
}

if p1 != nil && p2 == nil && p3 != nil{
return &Line{P1: *p1, P2: *p3}
if (*p1).RoundPlaces(6) != (*p3).RoundPlaces(6) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's remove such hardcode. Why 6?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l1va l1va l1va left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lelami @l1va