refactor: extract test stubs and fix lint

Author: l1va

src/settings_widget.py

@@ -3,7 +3,6 @@
 from PyQt5.QtWidgets import (
     QWidget,
     QLabel,
-    QLineEdit,
     QGridLayout,
     QCheckBox,
     QPushButton,
@@ -17,7 +16,7 @@
 
 from src import locales
 from src.settings import sett, APP_PATH, Settings, read_settings
-from src.qt_utils import ClickableLineEdit, LineEdit
+from src.qt_utils import ClickableLineEdit
 
 import os.path as path
 import logging

test/figure_editor_stubs.py

@@ -0,0 +1,39 @@
+import sys
+import types
+
+# Stubs for non-Qt dependencies used by FigureEditor
+
+settings_widget_module = types.ModuleType("src.settings_widget")
+
+
+class SettingsWidget:
+    def __init__(self, *args, **kwargs):
+        self.extra_sett_parameters = []
+        self.translation = {}
+
+    def from_settings(self, *args, **kwargs):
+        return self
+
+    def with_delete(self, *args, **kwargs):
+        return self
+
+    def with_sett(self, *args, **kwargs):
+        return self
+
+
+settings_widget_module.SettingsWidget = SettingsWidget
+sys.modules["src.settings_widget"] = settings_widget_module
+
+settings_module = types.ModuleType("src.settings")
+
+
+def sett():
+    return None
+
+
+settings_module.sett = sett
+sys.modules["src.settings"] = settings_module
+
+locales_module = types.ModuleType("src.locales")
+locales_module.getLocale = lambda x: x
+sys.modules["src.locales"] = locales_module

test/figure_editor_test.py

@@ -1,46 +1,7 @@
-import sys
-import types
 import unittest
 
 import qt_stubs  # noqa: F401
-
-# Stub out project-specific modules that depend on PyQt5
-settings_widget_module = types.ModuleType("src.settings_widget")
-
-
-class SettingsWidget:
-    def __init__(self, *args, **kwargs):
-        self.extra_sett_parameters = []
-        self.translation = {}
-
-    def from_settings(self, *args, **kwargs):
-        return self
-
-    def with_delete(self, *args, **kwargs):
-        return self
-
-    def with_sett(self, *args, **kwargs):
-        return self
-
-
-settings_widget_module.SettingsWidget = SettingsWidget
-sys.modules["src.settings_widget"] = settings_widget_module
-
-settings_module = types.ModuleType("src.settings")
-
-
-def sett():
-    return None
-
-
-settings_module.sett = sett
-sys.modules["src.settings"] = settings_module
-
-locales_module = types.ModuleType("src.locales")
-locales_module.getLocale = lambda x: x
-sys.modules["src.locales"] = locales_module
-
-# --- End stubs ---
+import figure_editor_stubs  # noqa: F401
 
 from src.figure_editor import FigureEditor
 

test/gcode_stubs.py

@@ -0,0 +1,48 @@
+import sys
+import types
+import importlib
+
+# Stubs for heavy dependencies not required for gcode parser tests
+
+
+def _prepare_transform(*args, **kwargs):
+    class _Tf:
+        def TransformPoint(self, pt):
+            return pt
+
+    return _Tf()
+
+
+gui_utils_module = types.ModuleType("src.gui_utils")
+gui_utils_module.prepareTransform = _prepare_transform
+sys.modules["src.gui_utils"] = gui_utils_module
+sys.modules["vtk"] = types.ModuleType("vtk")
+sys.modules["stk"] = types.ModuleType("stk")
+
+settings_module = types.ModuleType("src.settings")
+
+
+class _Hardware:
+    rotation_center_x = 0
+    rotation_center_y = 0
+    rotation_center_z = 0
+
+
+class _Slicing:
+    print_time = 0
+    consumption_material = 0
+    planes_contact_with_nozzle = ""
+
+
+_settings = types.SimpleNamespace(hardware=_Hardware(), slicing=_Slicing())
+
+
+def sett():
+    return _settings
+
+
+settings_module.sett = sett
+sys.modules["src.settings"] = settings_module
+
+src_pkg = importlib.import_module("src")
+src_pkg.settings = settings_module

test/gcode_test.py

@@ -1,63 +1,14 @@
 import unittest
-import sys
 import types
-import os
 
-# Ensure the src package can be imported
-sys.path.append(os.path.join(os.path.dirname(__file__), ".."))
+import gcode_stubs  # noqa: F401
 
-
-# Stub heavy dependencies not required for parser logic
-def _prepare_transform(*args, **kwargs):
-    class _Tf:
-        def TransformPoint(self, pt):
-            return pt
-
-    return _Tf()
-
-
-gui_utils_module = types.ModuleType("src.gui_utils")
-gui_utils_module.prepareTransform = _prepare_transform
-sys.modules["src.gui_utils"] = gui_utils_module
-sys.modules["vtk"] = types.ModuleType("vtk")
-sys.modules["stk"] = types.ModuleType("stk")
-
-settings_module = types.ModuleType("src.settings")
-
-
-class _Hardware:
-    rotation_center_x = 0
-    rotation_center_y = 0
-    rotation_center_z = 0
-
-
-class _Slicing:
-    print_time = 0
-    consumption_material = 0
-    planes_contact_with_nozzle = ""
-
-
-_settings = types.SimpleNamespace(hardware=_Hardware(), slicing=_Slicing())
-
-
-def sett():
-    return _settings
-
-
-settings_module.sett = sett
-
-import importlib
-
-src_pkg = importlib.import_module("src")
-src_pkg.settings = settings_module
-sys.modules["src.settings"] = settings_module
-
-from src.gcode import parseRotation, Rotation, parseGCode, Printer
+from src.gcode import parseRotation, parseGCode, Printer
 
 
 def parseArgs(args, X, Y, Z, abs_pos=True):
     """Wrapper around Printer to mimic legacy parseArgs behaviour."""
-    printer = Printer(sett())
+    printer = Printer(gcode_stubs.sett())
     printer.currPos = types.SimpleNamespace(X=X, Y=Y, Z=Z, U=0, V=0, E=0)
     if abs_pos:
         printer.setAbsPos(args)

test/qt_stubs.py

@@ -318,4 +318,3 @@ def setLocale(self, *args, **kwargs):
 sys.modules["PyQt5.QtCore"] = qtcore
 sys.modules["PyQt5.QtGui"] = qtgui
 sys.modules["sip"] = sip
-

test/settings_widget_reload_test.py

@@ -1,62 +1,8 @@
-import sys
-import types
 import unittest
 
 import qt_stubs  # noqa: F401
+import settings_widget_stubs  # noqa: F401
 
-# Stubs for non-Qt dependencies used by SettingsWidget
-vtk = types.ModuleType("vtk")
-
-
-class vtkNamedColors:
-    def GetColor3d(self, key):
-        return (0, 0, 0)
-
-
-vtk.vtkNamedColors = vtkNamedColors
-sys.modules["vtk"] = vtk
-
-qt_utils_stub = types.ModuleType("src.qt_utils")
-qt_utils_stub.ClickableLineEdit = qt_stubs.QLineEdit
-qt_utils_stub.LineEdit = qt_stubs.QLineEdit
-sys.modules["src.qt_utils"] = qt_utils_stub
-
-settings_module = sys.modules.get("src.settings", types.ModuleType("src.settings"))
-
-
-class Settings:
-    def __init__(self, data=None):
-        if data is None:
-            data = {}
-        for k, v in data.items():
-            if isinstance(v, dict):
-                v = Settings(v)
-            setattr(self, k, v)
-
-
-settings_module.Settings = Settings
-settings_module.read_settings = lambda filename=None: {"slicing": {"fill_density": 0}}
-settings_module.APP_PATH = ""
-sys.modules["src.settings"] = settings_module
-
-# Stub locales module expected by SettingsWidget
-locales_module = types.ModuleType("src.locales")
-
-
-class Locale:
-    GroupNames = {}
-    Settings = "Settings"
-    FillDensity = "Fill Density"
-
-    def __getattr__(self, item):
-        return item
-
-
-locales_module.Locale = Locale
-locales_module.getLocale = lambda: Locale()
-sys.modules["src.locales"] = locales_module
-
-sys.modules.pop("src.settings_widget", None)
 from src.settings_widget import SettingsWidget
 from src.settings import Settings
 
@@ -74,4 +20,3 @@ def test_reload_repopulates(self):
 
 if __name__ == "__main__":
     unittest.main()
-

test/settings_widget_stubs.py

@@ -0,0 +1,61 @@
+import sys
+import types
+
+import qt_stubs  # noqa: F401
+
+# Ensure real SettingsWidget can be imported even if previous tests stubbed it
+sys.modules.pop("src.settings_widget", None)
+
+# Stub vtk dependency
+vtk = types.ModuleType("vtk")
+
+
+class vtkNamedColors:
+    def GetColor3d(self, key):
+        return (0, 0, 0)
+
+
+vtk.vtkNamedColors = vtkNamedColors
+sys.modules["vtk"] = vtk
+
+# Stub Qt utility helpers
+qt_utils_stub = types.ModuleType("src.qt_utils")
+qt_utils_stub.ClickableLineEdit = qt_stubs.QLineEdit
+qt_utils_stub.LineEdit = qt_stubs.QLineEdit
+sys.modules["src.qt_utils"] = qt_utils_stub
+
+# Stub settings module used by SettingsWidget
+settings_module = sys.modules.get("src.settings", types.ModuleType("src.settings"))
+
+
+class Settings:
+    def __init__(self, data=None):
+        if data is None:
+            data = {}
+        for k, v in data.items():
+            if isinstance(v, dict):
+                v = Settings(v)
+            setattr(self, k, v)
+
+
+settings_module.Settings = Settings
+settings_module.read_settings = lambda filename=None: {"slicing": {"fill_density": 0}}
+settings_module.APP_PATH = ""
+sys.modules["src.settings"] = settings_module
+
+# Stub locales expected by SettingsWidget
+locales_module = types.ModuleType("src.locales")
+
+
+class Locale:
+    GroupNames = {}
+    Settings = "Settings"
+    FillDensity = "Fill Density"
+
+    def __getattr__(self, item):
+        return item
+
+
+locales_module.Locale = Locale
+locales_module.getLocale = lambda: Locale()
+sys.modules["src.locales"] = locales_module