(dbscan) Use valid index for neighbors#100
Open
ezheidtmann wants to merge 1 commit intoeriklindernoren:masterfrom
Open
(dbscan) Use valid index for neighbors#100ezheidtmann wants to merge 1 commit intoeriklindernoren:masterfrom
ezheidtmann wants to merge 1 commit intoeriklindernoren:masterfrom
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DBSCAN implementation was producing garbage results for me because the
_get_neighborsfunction was returning the wrong indices for valid neighbors.If comparing a sample with higher index than the argument, the returned indices were off by 1.
This change fixes it.
PS thanks for this implementation! It's a better fit for my use-case, where speed is not important but avoiding
scipyis very convenient.