Skip to content

Commit 4042741

Browse files
committed
BUGFIX : already despawned object detection
1 parent 32fc0be commit 4042741

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

.idea/.idea.Unity-Object-Pooling/.idea/indexLayout.xml

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/.idea.Unity-Object-Pooling/.idea/workspace.xml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Assets/CustomTools/ObjectPooling/Scripts/ObjectPool/ObjectPooler.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ public void Despawn(GameObject obj)
9393
{
9494
PooledObjectType pooledObjectType = obj.GetComponent<IPooledObject>().PoolType;
9595

96-
if (pooledObjectType != null && _poolDictionary.ContainsKey(pooledObjectType))
96+
if (_poolDictionary.ContainsKey(pooledObjectType) && // check if there's a queued objects by that tag.
97+
_poolDictionary[pooledObjectType].Contains(gameObject)) // check if `obj` is already despawned
9798
{
9899

99100

@@ -111,7 +112,7 @@ public void Despawn(GameObject obj)
111112
}
112113
else
113114
{
114-
Debug.LogError("Trying to despawn object which is not pooled !");
115+
Debug.LogError("Trying to despawn object which is not pooled or object is already despawned !");
115116
}
116117

117118
}

0 commit comments

Comments
 (0)