chore: cleanup warnings from components during compilation (#228)

Author: finger563

components/cli/include/cli.hpp

@@ -119,17 +119,17 @@ class Cli : private cli::CliSession {
 
     // Configure UART. Note that REF_TICK is used so that the baud rate remains
     // correct while APB frequency is changing in light sleep mode.
-    const uart_config_t uart_config = {
-      .baud_rate = baud_rate,
-      .data_bits = UART_DATA_8_BITS,
-      .parity = UART_PARITY_DISABLE,
-      .stop_bits = UART_STOP_BITS_1,
+    uart_config_t uart_config;
+    memset(&uart_config, 0, sizeof(uart_config));
+    uart_config.baud_rate = baud_rate;
+    uart_config.data_bits = UART_DATA_8_BITS;
+    uart_config.parity = UART_PARITY_DISABLE;
+    uart_config.stop_bits = UART_STOP_BITS_1;
 #if CONFIG_IDF_TARGET_ESP32 || CONFIG_IDF_TARGET_ESP32S2
-      .source_clk = UART_SCLK_REF_TICK,
+    uart_config.source_clk = UART_SCLK_REF_TICK;
 #else
-      .source_clk = UART_SCLK_XTAL,
+    uart_config.source_clk = UART_SCLK_XTAL;
 #endif
-    };
     /* Install UART driver for interrupt-driven reads and writes */
     ESP_ERROR_CHECK(uart_driver_install(port, 256, 0, 0, NULL, 0));
     ESP_ERROR_CHECK(uart_param_config(port, &uart_config));
@@ -214,7 +214,7 @@ class Cli : private cli::CliSession {
     setvbuf(stdin, nullptr, _IONBF, 0);
 
     // Register the USB CDC interface
-    auto err = esp_vfs_register(dev_name.data(), &vfs, NULL);
+    [[maybe_unused]] auto err = esp_vfs_register(dev_name.data(), &vfs, NULL);
 
     // TODO: this function is mostly untested, so we should probably add some
     //       error handling here and store the resultant pointers for later use

components/event_manager/src/event_manager.cpp

@@ -20,7 +20,8 @@ bool EventManager::add_publisher(const std::string &topic, const std::string &co
 bool EventManager::add_subscriber(const std::string &topic, const std::string &component,
                                   const event_callback_fn &callback,
                                   const size_t stack_size_bytes) {
-  return add_subscriber(topic, component, callback, {.stack_size_bytes = stack_size_bytes});
+  return add_subscriber(topic, component, callback,
+                        {.name = "", .stack_size_bytes = stack_size_bytes});
 }
 
 bool EventManager::add_subscriber(const std::string &topic, const std::string &component,

components/gfps_service/CMakeLists.txt

@@ -18,3 +18,5 @@ add_definitions(-DNEARBY_FP_RETROACTIVE_PAIRING=1) # not sure what this is...
 add_definitions(-DNEARBY_FP_BLE_ONLY=1)
 add_definitions(-DNEARBY_FP_PREFER_BLE_BONDING=1)
 add_definitions(-DNEARBY_FP_PREFER_LE_TRANSPORT=1)
+
+target_compile_options(${COMPONENT_LIB} PRIVATE -Wno-type-limits -Wno-write-strings)

components/gfps_service/include/gfps_service.hpp

@@ -195,10 +195,10 @@ class GfpsService : public espp::BaseComponent {
 
 protected:
   static constexpr uint16_t SERVICE_UUID = 0xFE2C;
-  static constexpr char *MODEL_ID_UUID = "fe2c1233-8366-4814-8eb0-01de32100bea";
-  static constexpr char *KB_PAIRING_UUID = "fe2c1234-8366-4814-8eb0-01de32100bea";
-  static constexpr char *PASSKEY_UUID = "fe2c1235-8366-4814-8eb0-01de32100bea";
-  static constexpr char *ACCOUNT_KEY_UUID = "fe2c1236-8366-4814-8eb0-01de32100bea";
+  static const std::string MODEL_ID_UUID;
+  static const std::string KB_PAIRING_UUID;
+  static const std::string PASSKEY_UUID;
+  static const std::string ACCOUNT_KEY_UUID;
 
   void make_service(NimBLEServer *server) {
     if (service_) {

components/gfps_service/src/gfps_service.cpp

@@ -0,0 +1,6 @@
+#include "gfps_service.hpp"
+
+const std::string espp::GfpsService::MODEL_ID_UUID = "fe2c1233-8366-4814-8eb0-01de32100bea";
+const std::string espp::GfpsService::KB_PAIRING_UUID = "fe2c1234-8366-4814-8eb0-01de32100bea";
+const std::string espp::GfpsService::PASSKEY_UUID = "fe2c1235-8366-4814-8eb0-01de32100bea";
+const std::string espp::GfpsService::ACCOUNT_KEY_UUID = "fe2c1236-8366-4814-8eb0-01de32100bea";

components/led/include/led.hpp

@@ -60,7 +60,7 @@ class Led : public BaseComponent {
    * @brief Initialize the LEDC subsystem according to the configuration.
    * @param config The configuration structure for the LEDC subsystem.
    */
-  explicit Led(const Config &config)
+  explicit Led(const Config &config) noexcept
       : BaseComponent("Led", config.log_level)
       , duty_resolution_(config.duty_resolution)
       , max_raw_duty_((uint32_t)(std::pow(2, (int)duty_resolution_) - 1))
@@ -77,7 +77,7 @@ class Led : public BaseComponent {
     ledc_timer_config(&ledc_timer);
 
     logger_.info("Initializing channels");
-    for (auto conf : channels_) {
+    for (const auto &conf : channels_) {
       uint32_t actual_duty = std::clamp(conf.duty, 0.0f, 100.0f) * max_raw_duty_ / 100.0f;
       ledc_channel_config_t channel_conf;
       memset(&channel_conf, 0, sizeof(channel_conf));