Support for hardware qualifiers (Flash + PSRAM) in manifests#690
Open
daggerrz wants to merge 3 commits into
Open
Support for hardware qualifiers (Flash + PSRAM) in manifests#690daggerrz wants to merge 3 commits into
daggerrz wants to merge 3 commits into
Conversation
Lint manifest and flash
…res detected Lint diagnostics
e7cec8c to
673b428
Compare
Contributor
|
The approach can not work. The gathered infos are incomplete. There is no Info about PSRAM Type QIO / OPI furthermore when PSRAM is not embedded it will not announced at all. There is simply no info about stored anywhere. |
|
Which hardware did you test against @daggerrz ? |
Author
|
It definitely works for detecting the difference between ESP32-S3 modules with and without embedded PSRAM, which is one of the common modules that are hard for users of WLED to choose between. I have also tested half a dozen other board with Espressif modules that were detected correctly. I can put together a complete matrix of the hardware tested, if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for more fine grained targeting to sepcific hardware. The ESP32-S3 modules, for example, comes with several configurations of flash and PSRAM and this PR makes it possible to target them individually.
Summary
Manifest example
{ "name": "My Firmware", "version": "1.0.0", "builds": [ { "chipFamily": "ESP32-S3", "flashSizeMB": 16, "psramSizeMB": 8, "parts": [{ "path": "s3-16mb-8psram.bin", "offset": 0 }] }, { "chipFamily": "ESP32-S3", "flashSizeMB": 4, "parts": [{ "path": "s3-4mb.bin", "offset": 0 }] }, { "chipFamily": "ESP32-S3", "parts": [{ "path": "s3-generic.bin", "offset": 0 }] } ] }A device with an ESP32-S3, 16 MB flash, and 8 MB PSRAM gets the first build. A 4 MB device gets the second. Any other ESP32-S3 falls back to the third.