-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[ld2412] New component docs #5071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
How can I add the image? It seems that the way I did it is wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this --it's great! Just some comments with general clean-up.
If you disagree with any of these changes, please comment back & let's discuss. Otherwise, I'm good with this. 👍🏻
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@Rihan9 I marked the comments above as "unresolved" as I don't see that those changes have been committed in this PR. If you marked them as "resolved" to indicate that you are ok with the suggestions, please let me know and/or just accept & commit them to the branch. In general, don't mark comments as "resolved" until the changes are committed & pushed or you & the reviewer have agreed to some other resolution. 🙂 |
Hi @kbx81 I finnaly found 5 minutes to made all the changes that you suggested and commit them. Sorry for the long wait |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Rihan9 🍻
Description:
Related issue (if applicable): fixes
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/index.rst
when creating new documents for new components or cookbook.