Skip to content

[ld2412] New component docs #5071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: next
Choose a base branch
from
Open

[ld2412] New component docs #5071

wants to merge 10 commits into from

Conversation

Rihan9
Copy link

@Rihan9 Rihan9 commented Jul 5, 2025

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable):

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/index.rst when creating new documents for new components or cookbook.

Copy link

netlify bot commented Jul 5, 2025

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit 58f558f
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/6876bcff757b2b00082bb3c1
😎 Deploy Preview https://deploy-preview-5071--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Rihan9
Copy link
Author

Rihan9 commented Jul 5, 2025

How can I add the image? It seems that the way I did it is wrong

Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this --it's great! Just some comments with general clean-up.

If you disagree with any of these changes, please comment back & let's discuss. Otherwise, I'm good with this. 👍🏻

@esphome
Copy link

esphome bot commented Jul 6, 2025

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft July 6, 2025 00:13
@kbx81 kbx81 changed the title Next [ld2412] New component docs Jul 6, 2025
@kbx81 kbx81 mentioned this pull request Jul 6, 2025
14 tasks
@kbx81
Copy link
Member

kbx81 commented Jul 7, 2025

@Rihan9 I marked the comments above as "unresolved" as I don't see that those changes have been committed in this PR. If you marked them as "resolved" to indicate that you are ok with the suggestions, please let me know and/or just accept & commit them to the branch.

In general, don't mark comments as "resolved" until the changes are committed & pushed or you & the reviewer have agreed to some other resolution. 🙂

@Rihan9
Copy link
Author

Rihan9 commented Jul 13, 2025

Hi @kbx81 I finnaly found 5 minutes to made all the changes that you suggested and commit them. Sorry for the long wait

@kbx81 kbx81 marked this pull request as ready for review July 15, 2025 01:44
@esphome esphome bot requested a review from kbx81 July 15, 2025 01:44
Copy link
Member

@kbx81 kbx81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Rihan9 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants