Skip to content

docs(whirlpool): 📝 new model DG11J1-39#6022

Open
stmlex wants to merge 2 commits intoesphome:nextfrom
stmlex:feature/whirlpool-DG11J1-39
Open

docs(whirlpool): 📝 new model DG11J1-39#6022
stmlex wants to merge 2 commits intoesphome:nextfrom
stmlex:feature/whirlpool-DG11J1-39

Conversation

@stmlex
Copy link

@stmlex stmlex commented Feb 2, 2026

Description:

Related issue (if applicable): fixes

Pull request in esphome with YAML changes (if applicable):

Checklist:

  • I am merging into next because this is new documentation that has a matching pull-request in esphome as linked above.
    or

  • I am merging into current because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.

  • Link added in /components/_index.md when creating new documents for new components or cookbook.

New Component Images

If you are adding a new component to ESPHome, you can automatically generate a standardized black and white component name image for the documentation.

To generate a component image:

  1. Comment on this pull request with the following command, replacing component_name with your component name in lower_case format with underscores (e.g., bme280, sht3x, dallas_temp):

    @esphomebot generate image component_name
    
  2. The ESPHome bot will respond with a downloadable ZIP file containing the SVG image.

  3. Extract the SVG file and place it in the /static/images/ folder of this repository.

  4. Use the image in your component's index table entry in /components/_index.md.

Example: For a component called "DHT22 Temperature Sensor", use:

@esphomebot generate image dht22

esphome[bot]
esphome bot previously requested changes Feb 2, 2026
Copy link

@esphome esphome bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.

@esphome
Copy link

esphome bot commented Feb 2, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome esphome bot marked this pull request as draft February 2, 2026 07:26
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Walkthrough

Added a new Whirlpool infrared climate model DG11J1-39 with temperature range 18-32°C to the climate IR component documentation. Single-line addition with no functional or structural changes.

Changes

Cohort / File(s) Summary
Climate IR Documentation
content/components/climate/climate_ir.md
Added Whirlpool DG11J1-39 model specification with temperature range 18-32°C.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

has-parent

Suggested reviewers

  • jesserockz
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'docs(whirlpool): 📝 new model DG11J1-39' accurately describes the main change: adding documentation for a new Whirlpool model DG11J1-39.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes adding documentation for a new Whirlpool model DG11J1-39, which directly aligns with the changeset.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
content/components/climate/climate_ir.md (1)

287-287: ⚠️ Potential issue | 🟡 Minor

Update the model count from "two" to "three".

The documentation states "There are two valid models to choose from:" but with the addition of DG11J1-39, there are now three valid models listed.

📝 Proposed fix
-- **model** (*Optional*, string): There are two valid models to choose from:
+- **model** (*Optional*, string): There are three valid models to choose from:

@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for esphome ready!

Name Link
🔨 Latest commit a791f12
🔍 Latest deploy log https://app.netlify.com/projects/esphome/deploys/698057a331f07600084cbe67
😎 Deploy Preview https://deploy-preview-6022--esphome.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

esphome[bot]
esphome bot previously requested changes Feb 2, 2026
Copy link

@esphome esphome bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.

@stmlex stmlex changed the base branch from current to next February 2, 2026 07:51
@esphome esphome bot added the next label Feb 2, 2026
@esphome esphome bot dismissed their stale review February 2, 2026 07:51

Base branch has been corrected - dismissing previous review.

@stmlex stmlex force-pushed the feature/whirlpool-DG11J1-39 branch from 04b5875 to a791f12 Compare February 2, 2026 07:52
@esphome esphome bot dismissed their stale review February 2, 2026 07:52

Base branch has been corrected - dismissing previous review.

@stmlex stmlex marked this pull request as ready for review February 2, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant