feat(LEDC): Add Gamma Fade support and enhance auto channel/timer selection for multi-group #11464
+428
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 12m 52s ⏱️ Results for commit ca7ad62. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
me-no-dev
reviewed
Jun 16, 2025
libraries/ESP32/examples/AnalogOut/LEDCGammaFade/LEDCGammaFade.ino
Outdated
Show resolved
Hide resolved
me-no-dev
reviewed
Jun 16, 2025
libraries/ESP32/examples/AnalogOut/LEDCGammaFade/LEDCGammaFade.ino
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull Request Overview
This PR adds gamma curve fade support and improves auto channel/timer selection in the ESP32 LEDC HAL. It introduces new API functions for gamma fade (including LUT and mathematical gamma correction), refines channel grouping logic using SOC_LEDC_CHANNEL_NUM, and enhances error handling during LEDC operations.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libraries/ESP32/examples/AnalogOut/LEDCGammaFade/ci.json | Adds a CI configuration requirement for gamma curve fade support. |
| libraries/ESP32/examples/AnalogOut/LEDCGammaFade/LEDCGammaFade.ino | Provides an example demo for gamma fading; note a mismatch between constant value and comment. |
| cores/esp32/esp32-hal-ledc.h | Declares new API functions for gamma fade support. |
| cores/esp32/esp32-hal-ledc.c | Implements gamma fade functionality and refines channel grouping, error handling, and timer selection. |
me-no-dev
approved these changes
Jun 16, 2025
me-no-dev
added
Status: Pending Merge
github-project-automation
bot
moved this from In Review
to Done
in Arduino ESP32 Core Project Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This pull request introduces several updates to the LEDC (LED Controller) functionality in the ESP32 HAL, focusing on improving compatibility, expanding functionality, and enhancing error handling. The most significant changes include replacing hardcoded channel group sizes with
SOC_LEDC_CHANNEL_NUM, adding support for gamma curve fades, and improving error handling in key LEDC operations.New Gamma Curve Fade Functionality:
ledcSetGammaTable,ledcClearGammaTable,ledcSetGammaFactor, andledcFadeGammaConfig. This functionality is available for SoCs with Gamma fade support like ESP32-C6, C5, H2, P4.Tests scenarios
Channel/Timer management tested using ESP32 and customized ledc example.
Gamma Fade tested using the ESP32C6 and provided new GammaFade example.
Related links
Closes #8790