Skip to content

Conversation

nebkat
Copy link
Contributor

@nebkat nebkat commented Jan 7, 2025

Description

Fixes auto coloring for different timestamp formats (including future formats as per https://github.com/espressif/esp-idf/blob/master/components/log/Kconfig.format).

Related

Introduced in d49533f

Testing

image


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link

github-actions bot commented Jan 7, 2025

Warnings
⚠️ The PR description looks very brief, please check if more details can be added.

👋 Welcome nebkat, thank you for your first contribution to espressif/esp-idf-monitor project!

📘 Please check project Contributions Guide of the project for the contribution checklist, information regarding code and documentation style, testing and other topics.

Pull request review and merge process you can expect

We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  4. If the change is approved and passes the tests it is merged into the default branch

🔁 You can re-run automatic PR checks by retrying the DangerJS action


⚠️ Deprecation Notice: This GitHub action is scheduled for removal in March 2024. We recommend migrating to the latest version available in the shared-github-danger project.

Generated by 🚫 dangerJS against a96991f

@github-actions github-actions bot changed the title fix: Auto color for alternative timestamp formats fix: Auto color for alternative timestamp formats (IDFGH-14376) Jan 7, 2025
@espressif-bot espressif-bot merged commit a96991f into espressif:master Jan 14, 2025
2 checks passed
@peterdragun
Copy link
Collaborator

Hi @nebkat, thank you for spotting the issue and creating the fix for it, it is much appreciated!

@nebkat nebkat deleted the fix/auto-color-timestamp branch January 14, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants