Feature/auth module #85
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…minio SecureStorage
…ureStorage para inyección de dependencias - Implementa test unitario realista (happy path) para KeychainSecureStorage usando spy bajo protocolo KeychainProtocol. - Refactoriza KeychainSecureStorage para aceptar KeychainProtocol por inyección. - Actualiza BDD-Security-Features.md reflejando avance de tests unitarios completados y dejando la integración real con Keychain como siguiente paso.
…BDD actualizado. Cobertura total de tests (happy y sad path).
… definition in production; tests and production share the same protocol. All tests passing. Clean architecture and modularity enforced.
…native, update tests and BDD, ready for next BDD step
- Refactorización SOLID: separación de KeychainProtocol y SystemKeychain - Eliminación de archivos obsoletos y actualización de referencias en Xcode - Actualización de BDD reflejando el caso como completado - Verificación de tests y cobertura de errores de datos corruptos
…tion test (TDD/BDD step)
…o y verificado por tests. BDD actualizado. Ciclo TDD/BDD cerrado.
…d by tests. BDD updated. TDD/BDD cycle closed.
…eloper progress. Acceptance scenarios remain as QA/business reference.
…ent integration tests passing and test infra improved (session isolation, stub usage).
…stro al servidor con cobertura de test automatizado y trazabilidad en BDD
… storage ensured, HTTPClientSpy configurable, codebase aligned with TDD/SOLID
… helper refactored. All tests passing. Ready for next sad path (connectivity).
…oadmap in README for maximum project clarity
…te BDD documentation
…ividad implementados y documentados
…suite verificada en iPhone 16 Pro, iOS 18.4
…istrationNotifier, test y flujo completado)
…Markdown/StackEdit compatibility. Add supporting text for clarity. Documentation now fully compatible with Mermaid in all supported editors.
…Markdown/StackEdit compatibility. Add supporting text for clarity. Documentation now fully compatible with Mermaid in all supported editors.feat: ✅ Completa caso de uso 'Almacenamiento Seguro' (SecureStorage) - Refactorización SOLID: separación de KeychainProtocol y SystemKeychain - Eliminación de archivos obsoletos y actualización de referencias en Xcode - Actualización de BDD reflejando el caso como completado - Verificación de tests y cobertura de errores de datos corruptos
- Refactor test to support async notification using XCTestExpectation and async/await fulfillment. - Enhance to accept an optional closure for async test synchronization. - Remove duplicate code and ensure clean formatting. - All tests passing under Swift 6 and Clean Architecture. - Strengthen validation for not saving credentials on error and correct notifier invocation.
…c (empty, spaces, failure, deletion)
…tegration test with spy, unicode/large data support, and DI refactor
…ror handling The commit adds integration tests for SystemKeychain to validate real Keychain operations and improves test coverage for error handling
…d apply private helpers for clarity and robustness in saveDirectly and Keychain flow. Centralize duplicate handling and improve maintainability.
… critical modules, exclusions and audit notes. Reflects current state as of 2025-04-23.
…ndling The commit adds integration tests to ensure no network calls are made on validation errors, improves input validation with whitespace
Member
|
Hi @SwiftEnProfundidad, we're not accepting PRs for this codebase. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.