Skip to content

refactor(esx_mechanicjob): code structure#65

Merged
N0tNvll merged 3 commits intodevfrom
unknown repository
Oct 11, 2025
Merged

refactor(esx_mechanicjob): code structure#65
N0tNvll merged 3 commits intodevfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Sep 27, 2025

Description

This PR reorganizes and updates the server-side logic, implementing spam prevention for harvest and craft actions to avoid abuse.

PR Checklist

  • My commit messages and PR title follow the Conventional Commits standard.
  • My changes have been tested locally and function as expected.
  • My PR does not introduce any breaking changes.
  • I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

Rafael Antunes added 2 commits September 27, 2025 10:18
### Description

This PR reorganizes and updates the server-side logic, implementing spam prevention for harvest and craft actions to avoid abuse.

### PR Checklist

- [X] My commit messages and PR title follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/?utm_source=chatgpt.com) standard.
- [X] My changes have been tested locally and function as expected.
- [X] My PR does not introduce any breaking changes.
- [X] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.
@ghost ghost changed the base branch from main to dev September 30, 2025 21:21
@FBFezz
Copy link
Contributor

FBFezz commented Oct 1, 2025

Placing Object doesn't seem to work also cleaning doesn't seem to work

@N0tNvll N0tNvll merged commit 65d302f into esx-framework:dev Oct 11, 2025
@N0tNvll
Copy link
Contributor

N0tNvll commented Oct 12, 2025

{24BBD1F1-2F95-44D4-B8D3-CA15AFB7D6E0} Are you checking the jobs?

The alert keeps showing i need to go again to the alert to hide it

{216CBA86-4303-42FE-B79E-177A504AFB49}

Skin issues

{BE0C7DDC-8642-49F8-B32D-44E293C7BD44}

This mark is showing without beeing in a vehicle would be good to hide and add a blip to reference

{DE97D535-0152-400E-9C75-35D31FE39BCA}

@ghost
Copy link
Author

ghost commented Oct 12, 2025

{24BBD1F1-2F95-44D4-B8D3-CA15AFB7D6E0} Are you checking the jobs?

The alert keeps showing i need to go again to the alert to hide it
{216CBA86-4303-42FE-B79E-177A504AFB49}

Skin issues
{BE0C7DDC-8642-49F8-B32D-44E293C7BD44}

This mark is showing without beeing in a vehicle would be good to hide and add a blip to reference
{DE97D535-0152-400E-9C75-35D31FE39BCA}

The problems you reported have been fixed. As for the skin, there are no errors in my tests — we just need to put the outfit in the skin column. The other error, ‘press [E] to Personalise Your Vehicle,’ belongs to the esx_lscustom script.

#83 (mechanicjob)

#84 (lscustom)

@N0tNvll
Copy link
Contributor

N0tNvll commented Oct 12, 2025

Have been fixed where? is the same i took your changes and put into the branch dev

@N0tNvll
Copy link
Contributor

N0tNvll commented Oct 12, 2025

screenshot 2025-10-12 a las 14 26 08 All your changes are in dev branch i tested yesterday and i was having this issues

@ghost
Copy link
Author

ghost commented Oct 12, 2025

I create a new pr...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants