Policejob major update:

[MaitreAntho]

Changes

• Refactored client/main.lua (FreezePlayer, PlayerPedId usage, thread cleanup)
• Refactored server/main.lua (secured buyWeapon/buyVehicle, account choice, MySQL checks)
• Added Config.ArmoryAccount (money/bank) for armory purchases
• Improved shared/permissions.lua and constants.lua handling
• Fixed weapon purchase error and removed redundant code

Description

• This PR improves esx_policejob by cleaning redundant code, adding configuration options, and securing sensitive logic. The goal is to provide a more maintainable and secure implementation while fixing common issues related to weapon purchases and performance.

Motivation

• Prevent potential exploits in weapon and vehicle purchases
• Provide flexibility in payment method configuration (money or bank)
• Improve overall code quality and maintainability
• Implementation Details
• Unified usage of PlayerPedId
• Added validation and SQL checks for purchases
• Introduced Config.ArmoryAccount to manage purchase account source
• Cleaned unnecessary threads and code duplication

[FBFezz]

Maybe add a soft and hard cuff option instead of freezeplayer with controls that are disabled or not for each?

[MaitreAntho]

Oh yeah, that's a good idea, I didn't have it at the time. I'll take care of it in the afternoon.

[N0tNvll]

I see different things that you can continue refactorizing and separate in different files to have a better readable

At the same time i see this news implementations
[esx_addons]/esx_policejob/shared/constants.lua
[esx_addons]/esx_policejob/shared/permissions.lua

Did you test it that it works good?

[N0tNvll]

Did you check the script at all?

Its using different languages some parts are taking the convar and others the english language check that

Use POLICE var directly pls

The rest apparently to have a good readable like expected

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}