refactor: improve banking money handling to prevent potential exploit#98
Open
AlexRXWindy wants to merge 1 commit intoesx-framework:devfrom
Open
refactor: improve banking money handling to prevent potential exploit#98AlexRXWindy wants to merge 1 commit intoesx-framework:devfrom
AlexRXWindy wants to merge 1 commit intoesx-framework:devfrom
Conversation
|
Hey @AlexRXWindy , thanks for the PR! The idea of adding rollback logic is good, but there's a critical issue: ESX's addAccountMoney() and removeAccountMoney() don't return boolean values - they return nil. This means your checks Suggested fix: Check balance before operations instead: Also minor: please use xPlayer.source consistently (not xPlayer.src). |
simpleC0de
requested changes
Jan 23, 2026
simpleC0de
left a comment
There was a problem hiding this comment.
See comment above - the ESX functions don't return booleans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors and improves the money-handling logic within the ESX Banking system.
The refactor enhances both security and stability while maintaining backward compatibility with existing ESX Banking functionality.