Fixing an issue with missing propTypes #36
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't really understand the issue, but this fixes ethanselzer#35 by: 1. providing an empty object to Object.keys as a default 2. only emitting the event when there's actually something to send along with it This fixes an issue I was having with another component using this one (ethanselzer/react-image-magnify)
|
I have tested the PR and it solves the issue. Please merge! |
|
@ethanselzer when can we expect this PR to be merged as this is a blockage in our production deployment, so knowing an expected time we can plan accordingly. |
|
@ethanselzer @jacekradko can anybody merge this PR? |
|
To anyone having issues with this library, I have found this alternative which seems to work well: laurenashpole/react-inner-image-zoom |
|
@ethanselzer @jacekradko can anybody merge this PR, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't really understand the issue, but this fixes #35 by:
This fixes an issue I was having with another component using this one (ethanselzer/react-image-magnify)