chore(tests): workaround for EIP-6110 deposit log checks #2177
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds a workaround for the invalid deposit log tests for Geth/Reth:
Geth
https://hive.ethpandaops.io/#/test/fusaka/1758206019-3d8e1ef2d1c0829ec602a80ba1b23b1d?testnumber=18233
Reth
https://hive.ethpandaops.io/#/test/fusaka/1758204471-aa8d60fbce3ef54fecbaf57a3fd84ef3?testnumber=17831
Spec Details
This means Geth/Reth are "technically" out of spec for EIP-6110.
From EIP-6110 we have the
is_valid_deposit_event_data
function. This first checks the log length, secondly the offsets and thirdly the sizes of the deposit event data.Although this is out of spec it is assumed that this workaround (Geth/Reth not implementing the checks) will not cause an issue, where the mainnet/testnet deposit contracts will not change.
🔗 Related Issues or PRs
PR to implement these checks in Geth/Reth:
If Geth/Reth prefer not to add these checks then we will merge this PR in EEST instead.
✅ Checklist
tox
checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
type(scope):
.