Skip to content

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Sep 19, 2025

🗒️ Description

Adds a workaround for the invalid deposit log tests for Geth/Reth:

  • Reth doesn't check the length of the deposit logs.
  • Geth/Reth don't check the offsets and the sizes of the deposit logs.

Geth

https://hive.ethpandaops.io/#/test/fusaka/1758206019-3d8e1ef2d1c0829ec602a80ba1b23b1d?testnumber=18233

Reth

https://hive.ethpandaops.io/#/test/fusaka/1758204471-aa8d60fbce3ef54fecbaf57a3fd84ef3?testnumber=17831

Spec Details

This means Geth/Reth are "technically" out of spec for EIP-6110.

From EIP-6110 we have the is_valid_deposit_event_data function. This first checks the log length, secondly the offsets and thirdly the sizes of the deposit event data.

Although this is out of spec it is assumed that this workaround (Geth/Reth not implementing the checks) will not cause an issue, where the mainnet/testnet deposit contracts will not change.

🔗 Related Issues or PRs

PR to implement these checks in Geth/Reth:

If Geth/Reth prefer not to add these checks then we will merge this PR in EEST instead.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx --with=tox-uv tox -e lint,typecheck,spellcheck,markdownlint
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore fork:prague Prague hardfork labels Sep 19, 2025
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing so hard for this and getting green 🙏

Appreciate the explanations, seems a reasonable compromise to get closure.

I just future-proofed the comments for line-length 79 😆

@spencer-tb spencer-tb merged commit 50cbabd into main Sep 26, 2025
27 of 30 checks passed
@spencer-tb spencer-tb deleted the 6110-exception-workaround branch September 26, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:prague Prague hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants