Skip to content

chore(tests): workaround for EIP-6110 deposit log checks #2177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

chore(tests): workaround for EIP-6110 deposit log checks #2177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
269d616
chore(tests): workaround for EIP-6110 deposit log checks.
spencer-tb Sep 19, 2025
c2c6b35
chore(tests): future-proof comments for line-length 79
danceratopz Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions tests/prague/eip6110_deposits/test_modified_contract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,29 @@ def test_invalid_layout(
blockchain_test(
pre=pre,
blocks=[
Block(txs=[tx], exception=BlockException.INVALID_DEPOSIT_EVENT_LAYOUT),
Block(
txs=[tx],
exception=[
BlockException.INVALID_DEPOSIT_EVENT_LAYOUT,
BlockException.INVALID_REQUESTS,
# INVALID_REQUESTS is an alternative workaround for
# Geth/Reth only.
#
# Geth/Reth do not validate the sizes or offsets of the
# deposit contract logs.
#
# Although this is out of spec, it is understood that this
# will not cause an issue so long as the mainnet/testnet
# deposit contracts don't change.
#
# This offsets are checked second and the sizes are checked
# third within the `is_valid_deposit_event_data` function:
# https://eips.ethereum.org/EIPS/eip-6110#block-validity
#
# EELS definition for `is_valid_deposit_event_data`:
# https://github.com/ethereum/execution-specs/blob/5ddb904fa7ba27daeff423e78466744c51e8cb6a/src/ethereum/forks/prague/requests.py#L51
],
),
],
post={},
)
Expand Down Expand Up @@ -251,7 +273,29 @@ def test_invalid_log_length(blockchain_test: BlockchainTestFiller, pre: Alloc, s
blockchain_test(
pre=pre,
blocks=[
Block(txs=[tx], exception=BlockException.INVALID_DEPOSIT_EVENT_LAYOUT),
Block(
txs=[tx],
exception=[
BlockException.INVALID_DEPOSIT_EVENT_LAYOUT,
BlockException.INVALID_REQUESTS,
# INVALID_REQUESTS is an alternative workaround for
# Geth/Reth only.
#
# Geth/Reth do not validate the sizes or offsets of the
# deposit contract logs.
#
# Although this is out of spec, it is understood that this
# will not cause an issue so long as the mainnet/testnet
# deposit contracts don't change.
#
# This offsets are checked second and the sizes are checked
# third within the `is_valid_deposit_event_data` function:
# https://eips.ethereum.org/EIPS/eip-6110#block-validity
#
# EELS definition for `is_valid_deposit_event_data`:
# https://github.com/ethereum/execution-specs/blob/5ddb904fa7ba27daeff423e78466744c51e8cb6a/src/ethereum/forks/prague/requests.py#L51
],
),
],
post={},
)
Loading