Add more complex selfdestruct tests #2207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raxhvl
changed the base branch from
main
to
feat/eip-7928/test-self-destruct
|
@fselmo I have pointed this to the self-destruct branch. I will cover these tests there, lets merge them together. |
fselmo
force-pushed
the
feat/eip-7928/test-self-destruct
branch
from
7a01039 to
366e454
Compare
raxhvl
merged commit b290901
into
ethereum:feat/eip-7928/test-self-destruct
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Add two new BAL test cas descriptions for contracts that are created and self-destructed within the same transaction.
test_bal_create2_to_A_read_then_selfdestruct: covers contract reading a storage slot before self-destruct.test_bal_create2_to_A_write_then_selfdestruct: covers contract writing to a storage slot before self-destruct.Both tests ensure BAL includes:
balance_changes.StorageKeyaccess.storage_changesfor B (due to ephemeral lifetime under EIP-6780 semantics).🔗 Related Issues or PRs
fselmo/execution-specs#10